Skip to content

fix(event-dispatcher): add support for multiple clients #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 4, 2021
Merged

fix(event-dispatcher): add support for multiple clients #402

merged 19 commits into from
May 4, 2021

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Apr 30, 2021 •
edited
Loading

Fix event-dispatcher to support multiple clients (sdkKeys).

  • full thread-safety for additional concurrency requirements
  • no resource conflicts for multiple sdkKeys support

@jaeopt jaeopt requested a review from a team as a code owner April 30, 2021 17:13
@jaeopt jaeopt removed their assignment Apr 30, 2021
@jaeopt jaeopt requested a review from yasirfolio3 April 30, 2021 17:13
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 90.316% when pulling d1dc2fe on jae/multi-event into 8488aa8 on master.

@coveralls
Copy link

coveralls commented Apr 30, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 90.28% when pulling f6164fa on jae/multi-event into 372b278 on master.

msohailhussain
msohailhussain reviewed May 3, 2021
View reviewed changes
msohailhussain
msohailhussain reviewed May 3, 2021
View reviewed changes
msohailhussain
msohailhussain previously approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
reviewed except multi-client unit test.

msohailhussain
msohailhussain approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt merged commit b56f9ba into master May 4, 2021
@jaeopt jaeopt deleted the jae/multi-event branch May 4, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

@yasirfolio3 yasirfolio3 Awaiting requested review from yasirfolio3

Assignees
No one assigned
Labels
🤖 20 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaeopt @coveralls @msohailhussain @optimizely-codereview-bot