Skip to content

fix: add support for multiple clients #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
May 26, 2021
Merged

fix: add support for multiple clients #410

merged 47 commits into from
May 26, 2021

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented May 21, 2021

This is an umbrella PR of several fixes to support multiple clients (sdkKeys).

  • full thread-safety for additional concurrency requirements
  • no resource conflicts for multiple sdkKeys support

jaeopt added 30 commits April 22, 2021 11:02
@jaeopt
add multi-client tests for datafile handler
e07ee4a
@jaeopt
fix datafile handler sync with atomic dictionary
b4153a0 
fix datafile handler sync with atomic dictionary

cleanup

clean up
@jaeopt
change name for AtomicWrapper
bfabdae
@jaeopt
remove extra line from custom xcode header
e7091de
@jaeopt
add more concurrent tests for datafile handler
6282d4d
@jaeopt
clean up
e21b11d
@jaeopt
change tests to a shared datafile handler
65d11fa
@jaeopt
fix atomic return
826d40b
@jaeopt
clean up
77fb808
@jaeopt
clean up
d6d9fac
@jaeopt
fix per review
e852348
@jaeopt
clean up
e375243
@jaeopt
clean up
5425df3
@jaeopt
clean up
5888f66
@jaeopt
add tests for concurrent event dispatcher
f741634
@jaeopt
clean up tests
181d86f
@jaeopt
add more tests for multi-client event dispatcher
d1dc2fe
@jaeopt
clean up
3a6aad9
@jaeopt
fix conflicts
0ae0fbd
@jaeopt
add tests for multi-client ups
34b0f9f
@jaeopt
add rmwlock for ups
5a73bc3
@jaeopt
add global ups lock
7be7064
@jaeopt
move a shred ups lock to decision-service
0c00ecc
@jaeopt
fix per review
32e3a55
@jaeopt
add logger tests for multi clients
61bd1b5
@jaeopt
fix handlerRegistryService to support multi clients
05ce575
@jaeopt
clean up
4a87114
@jaeopt
clean up logger
1d8b3f9
@jaeopt
clean up
6b4a847
@jaeopt
clean up
394ccfc
@jaeopt jaeopt requested a review from a team as a code owner May 21, 2021 20:16
@jaeopt jaeopt removed their assignment May 21, 2021
@coveralls
Copy link

coveralls commented May 21, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 89.937% when pulling 6fa4c4c on jae/multi-clients into c54dfb9 on master.

msohailhussain
msohailhussain previously approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

msohailhussain
msohailhussain approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt merged commit e232a67 into master May 26, 2021
@jaeopt jaeopt deleted the jae/multi-clients branch May 26, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasirfolio3 yasirfolio3 Awaiting requested review from yasirfolio3

1 more reviewer

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
🤖 20 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaeopt @coveralls @msohailhussain @optimizely-codereview-bot