Skip to content

fix(EventDispatcher): change eventEndPoint to public #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2021
Merged

fix(EventDispatcher): change eventEndPoint to public #438

merged 1 commit into from
Oct 22, 2021

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Oct 8, 2021

Summary

  • Change eventEndPoint to public so event target customization and testing gets easier.

Test plan

  • Add unit tests for customization + override

@jaeopt jaeopt requested a review from a team as a code owner October 8, 2021 21:57
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.294% when pulling 18e73b1 on jae/custom-urls into 1c686ad on master.

msohailhussain
msohailhussain approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt merged commit c084cbb into master Oct 22, 2021
@jaeopt jaeopt deleted the jae/custom-urls branch October 22, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jaeopt jaeopt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeopt @coveralls @msohailhussain