Skip to content

Conversation

yasirfolio3
Copy link
Contributor

@yasirfolio3 yasirfolio3 commented Mar 10, 2023

Issues

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of changes suggested

// limitations under the License.
//

/// Do not edit this field.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says - "Do not edit this field" :) It'll be auto-updated while preparing release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh thanks for pointing that out 👍

CHANGELOG.md Outdated
## 3.10.2
March 10, 2023

* Update readme. ([#479](https://github.com/optimizely/swift-sdk/pull/479)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use Griffin's release note here and release note.

@yasirfolio3 yasirfolio3 requested a review from jaeopt March 10, 2023 20:32
@yasirfolio3 yasirfolio3 changed the title chore: prepare for v3.10.2 release [FSSDK-8951] chore: prepare for v3.10.2 release Mar 10, 2023
@coveralls
Copy link

coveralls commented Mar 10, 2023

Coverage Status

Coverage: 95.245%. Remained the same when pulling cc9163c on yasir/prepare-3.10.2 into e638360 on master.

jaeopt
jaeopt previously approved these changes Mar 10, 2023
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - add a PR link

CHANGELOG.md Outdated
## 3.10.2
March 10, 2023

* We updated our README.md and other non-functional code to reflect that this SDK supports both Optimizely Feature Experimentation and Optimizely Full Stack.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a link to PR.

Copy link

@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yasirfolio3 yasirfolio3 merged commit 627aba5 into master Mar 14, 2023
@yasirfolio3 yasirfolio3 deleted the yasir/prepare-3.10.2 branch March 14, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants