[FSSDK-9062] add more support for sendOdpEvent error handling #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
changed the title
yasirfolio3
approved these changes
Apr 19, 2023
| simulator_xcode_version: 12.4 | ||
| - os: 13.7 | ||
| simulator_xcode_version: 13.4.1 | ||
| - os: 15.5 |
There was a problem hiding this comment.
can we test os 14 here? since we're already testing 15 above?
There was a problem hiding this comment.
github actions are terrible in supporting iOS. 15.5 and 16 are only available to macOS 12, which I need to workaround the hang issue. I'll try to extend the range when they get available.
| if: "${{ github.event.inputs.PREP == '' && github.event.inputs.RELEASE == '' }}" | ||
| uses: optimizely/swift-sdk/.github/workflows/unit_tests.yml@master | ||
| ##uses: optimizely/swift-sdk/.github/workflows/unit_tests.yml@master | ||
| uses: optimizely/swift-sdk/.github/workflows/unit_tests.yml@jae/empty-odp-action |
There was a problem hiding this comment.
Looks good overall, can we update to master before merging
There was a problem hiding this comment.
I'll update it with the next PR coming :)
Comment on lines
-81
to
+84
| # > ls /Applications/ | ||
| ##ls /Applications/ | ||
| # - to find supported simulator os versions, run this (and find simulator with non-error "datapath") | ||
| # > xcrun simctl list --json devices | ||
| ##xcrun simctl list --json devices |
There was a problem hiding this comment.
are these commands no longer required?
There was a problem hiding this comment.
They're just for debugging to check available iOS simulators etc installed in github actions VM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add more support for sendOdpEvent error handling:
Include other clean-ups:
Test plan
Issues