Fix param_mask for multivariate TPE with constant_liar
#4462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not522
added
the
bug
github-actions
bot
added
the
optuna.samplers
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #4462 +/- ##
==========================================
- Coverage 90.40% 89.66% -0.74%
==========================================
Files 172 178 +6
Lines 13682 13974 +292
==========================================
+ Hits 12369 12530 +161
- Misses 1313 1444 +131
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
knshnb
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
I confirmed the errors in both codes (#4459 (comment), #4459 (comment)) are resolved! LGTM.
|
I found #4079 accidentally introduced this bug. So, versions before 3.1.0 do not have it. |
cross32768
approved these changes
Mar 2, 2023
contramundum53
pushed a commit
that referenced
this pull request
Apr 3, 2023
Fix `param_mask` for multivariate TPE with `constant_liar`
HideakiImamura
added a commit
that referenced
this pull request
Apr 3, 2023
Backport #4462 for v3.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #4459.
When
multivariate=Trueandconstant_liar=True, running trials may partially sample parameters in a relative search space. In this case, we need to check all parameters to make the mask.Description of the changes
Check all parameters to make
param_mask.