Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Quill component to latest version #1842

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Update Quill component to latest version #1842

merged 1 commit into from
Dec 2, 2021

Conversation

leigh-pointer
Copy link
Contributor

Upgraded Quill references to 1.3.7
Tabnabbing vulnerability in snow theme #2438
slab/quill#2438

https://github.com/quilljs/quill/releases/tag/v1.3.7

Upgraded Quill references to 1.3.7
Tabnabbing vulnerability in snow theme #2438
slab/quill#2438

https://github.com/quilljs/quill/releases/tag/v1.3.7
@sbwalker sbwalker merged commit 9664ff6 into oqtane:dev Dec 2, 2021
@leigh-pointer leigh-pointer deleted the QuillEditor1.3.7-SecurityUpdate branch December 4, 2021 04:06
@sbwalker sbwalker changed the title Quill Security related bug fixes. Update Quill component to latest version Dec 9, 2021
@sbwalker
Copy link
Member

@leigh-pointer is there a reason why the quill 1.3.6 JS and CSS files were not removed from the wwwroot folders?

@leigh-pointer
Copy link
Contributor Author

No, i must have missed that, sorry!

@sbwalker
Copy link
Member

@leigh-pointer no worries.... I removed them now

@sbwalker
Copy link
Member

sbwalker commented Jun 24, 2022

@leigh-pointer I know this was contributed quite some time ago... but do you have any context on why you felt we needed to upgrade Quill to 1.3.7... and once Quill was upgraded, did you experience any issues - specifically were you still able to insert images using the rich text editor component in Oqtane? I am investigating #2252 and I can reproduce the problem locally however I am not sure how long this issue may have existed. It is possible that it was introduced in the upgrade to 1.3.7 so I was going to test a rollback to 1.3.6 but if there is a reason why we should not use 1.3.6 then I need the context.

@sbwalker
Copy link
Member

@leigh-pointer I am guessing that the Delta feature (which image insertion relies upon) may have been moved to a separate library https://quilljs.com/docs/delta/ in version 1.3.7?

@leigh-pointer
Copy link
Contributor Author

Some work needs to be done i guess!
Will try to sort it this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants