Skip to content

Update to Java 20 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2023
Merged

Update to Java 20 #54

merged 1 commit into from
Apr 19, 2023

Conversation

scordio
Copy link
Contributor

@scordio scordio commented Apr 18, 2023

JDK 20.0.1 has been released today yesterday and I've noticed some failures like this one.

I've taken inspiration from #41 for a fix, I hope I covered all the needed points.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 18, 2023
sormuras
sormuras approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci, Stefano. Changes look good to me.

@sormuras sormuras merged commit 8c9d5d4 into oracle-actions:main Apr 19, 2023
@scordio scordio deleted the fix_java_20 branch April 19, 2023 10:44
@scordio
Copy link
Contributor Author

scordio commented Apr 19, 2023

Looks good so far 👍 https://github.com/assertj/assertj/actions/runs/4739705996/jobs/8420640816

Thanks for merging!

@sormuras
Copy link
Member

The run you linked indicates that only the mapping file update was missing - as your workflow uses v1 of oracle-actions/setup-java. That update would/should have happend automatically today/or so.

Thanks for updating the defaults and documentation - we will release a new version of this action soon, with moving the v1 branch to that new release as well.

@scordio
Copy link
Contributor Author

scordio commented Apr 19, 2023

Wasn't the mapping file updated with 33f8639? Not sure I understood where the gap was.

@sormuras
Copy link
Member

Yes, you are right. The mapping was updated; yet the parser/lister (ListOpenJavaDevelopmentKits.java) was out of sync. This is what your PR fixed and generated the new mapping file - which now consumable by current @v1 and @main versions of this action alike.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sormuras sormuras sormuras approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scordio @sormuras