-
Notifications
You must be signed in to change notification settings - Fork 71
First sample #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First sample #2
Conversation
Details: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on this! There is a LOT of content and work that you've put into it. There are some comments I provided in the code that would be worth reviewing.
My main reason for requesting changes (besides some of the inline comments) is around the following images, which might be cleaned up a bit:
- oci-devops-examples/oci-build-examples/oci_buildrunner_with_sonarqube/images/sonar_tf_bug.png - remove the links to different apps/pages below the address bar
- oci-devops-examples/oci-deployment-examples/oci_helm_function_deployment/images/lb1.png - same as above (remove page/app bookmarks from screenshot)
- oci-devops-examples/oci-deployment-examples/oci_helm_function_deployment/images/oci_oke3.png - the compartment should be redacted more (in the Network Information window in the background)
- oci-devops-examples/oci-deployment-examples/oci_helm_function_deployment/images/sc1.png - the compartment path should be redacted (small text below the Resource Compartment box)
- oci-devops-examples/oci-pipeline-examples/oci-java-micronaut-devops-example/images/environment.png - compartment path should be redacted (small text below Compartment box)
- oci-devops-examples/oci-pipeline-examples/oci-java-micronaut-devops-example/images/lb.png - remove the app/page bookmarks from the screenshot
oci-pipeline-examples/oci-java-micronaut-devops-example/README.md
Outdated
Show resolved
Hide resolved
oci-pipeline-examples/oci-java-micronaut-devops-example/README.md
Outdated
Show resolved
Hide resolved
oci-pipeline-examples/oci-java-micronaut-devops-example/gradle.properties
Show resolved
Hide resolved
oci-pipeline-examples/oci-java-micronaut-devops-example/gradle.properties
Show resolved
Hide resolved
Thanks alot @timclegg for the detailed PR review , sorry for making you scan alots of files in one PR !! . I did adjust as per the PR and for the broader ask of a terraform stack for devops + common components , we will add to our backlog and will check and release according to the Oracle Devrel guidlines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
No description provided.