Skip to content

Conversation

RahulMR42
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 3, 2022

⚠️ WARNING: Missing Copyright Notice(s)
It's a good idea to have copyright notices at the top of each file. It looks like at least one file was missing this (though it might be further down in the file - this might be a false-positive).

Details:
⚠️ - :

@RahulMR42 RahulMR42 requested review from timclegg and removed request for timclegg March 3, 2022 16:03
Copy link
Contributor

@timclegg timclegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this! There is a LOT of content and work that you've put into it. There are some comments I provided in the code that would be worth reviewing.

My main reason for requesting changes (besides some of the inline comments) is around the following images, which might be cleaned up a bit:

  • oci-devops-examples/oci-build-examples/oci_buildrunner_with_sonarqube/images/sonar_tf_bug.png - remove the links to different apps/pages below the address bar
  • oci-devops-examples/oci-deployment-examples/oci_helm_function_deployment/images/lb1.png - same as above (remove page/app bookmarks from screenshot)
  • oci-devops-examples/oci-deployment-examples/oci_helm_function_deployment/images/oci_oke3.png - the compartment should be redacted more (in the Network Information window in the background)
  • oci-devops-examples/oci-deployment-examples/oci_helm_function_deployment/images/sc1.png - the compartment path should be redacted (small text below the Resource Compartment box)
  • oci-devops-examples/oci-pipeline-examples/oci-java-micronaut-devops-example/images/environment.png - compartment path should be redacted (small text below Compartment box)
  • oci-devops-examples/oci-pipeline-examples/oci-java-micronaut-devops-example/images/lb.png - remove the app/page bookmarks from the screenshot

@RahulMR42
Copy link
Collaborator Author

Thanks alot @timclegg for the detailed PR review , sorry for making you scan alots of files in one PR !! .

I did adjust as per the PR and for the broader ask of a terraform stack for devops + common components , we will add to our backlog and will check and release according to the Oracle Devrel guidlines.

Copy link
Contributor

@timclegg timclegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@RahulMR42 RahulMR42 merged commit eb727e7 into main Apr 7, 2022
@RahulMR42 RahulMR42 deleted the development branch April 7, 2022 06:21
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants