Joboon fix plsql auto increment #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing' into joboon-FixPLSQLAutoIncrement
oracle-contributor-agreement
bot
added
the
OCA Verified
aarrasseayoub01
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporate the changes from FixPLSQLAutoIncrement.
Issue 1
The PR fixes the issue of the previous commit which add supports of skipping quoting identifiers. The solution uses writeQuotedIdentifier directly, which fails when trying to avoid quoting the identifiers. Instead, it should go through db.QuoteTo so that the configuration option can decide whether to actually quote anything.
Issue 2
When updating a struct with a one-to-many relationship, the update attempts to insert NULL into the auto-increment field of the new row. The fix is simply to exclude auto-increment fields when generating the SQL.
This change also adds the test
TestSaveAssociationWithAutoIncrementFieldto verify the fix.