Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code sample - 23c BOOLEAN data type with JDBC + PLSQL23c jdbc bool plsql #311

Merged

Conversation

juarezjuniorgithub
Copy link
Member

Code sample - 23c BOOLEAN data type with JDBC + PLSQL
Signed-off-by: Juarez Barbosa juarez.barbosa@oracle.com

@juarezjuniorgithub
Copy link
Member Author

@Kuassim can you please approve this one as well? Thanks!

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 10, 2024
@juarezjuniorgithub
Copy link
Member Author

@jeandelavarene @Kuassim 2 spaces indentation + closing of JDBC resources double-checked.
Please check commit d33cd94 and approve. Thanks!

@juarezjuniorgithub
Copy link
Member Author

@jeandelavarene @Kuassim adjusted the 2 spaces indentation for POM on this one as well. Please check and approve. Thanks!

jeandelavarene
jeandelavarene previously approved these changes Jul 1, 2024
Copy link
Contributor

@jeandelavarene jeandelavarene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove 23c-jdbc-bool-plsql

@juarezjuniorgithub
Copy link
Member Author

@Kuassim @jeandelavarene removed the duplicated dir 23c-jdbc-bool-plsql. Please review, thanks.

@juarezjuniorgithub
Copy link
Member Author

We need to remove 23c-jdbc-bool-plsql

@Kuassim @jeandelavarene it's done.

@jeandelavarene jeandelavarene merged commit 8307edb into oracle-samples:main Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants