-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for mounting file storage for oci job #139
Conversation
|
||
Parameters | ||
---------- | ||
storage_mount : List[Union(DSCFileSystem, dict) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the format of the dict?
Could you please add code example here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The format would be something as this
.with_storage_mount(
{
storage_type="FILE_STORAGE",
destination_directory_name="test_folder_name",
export_path="test_export_path",
mount_target="test_mount_target"
},
{
storage_type="OBJECT_STORAGE",
destination_directory_name="test_folder_name",
namespace="test_namespace",
path="test_path"
},
)
Two keys are required for each dict: storage_type
and destination_directory_name
The other keys need to be provided based on which type of file systems users would like to mount. For file storage, these are export_path
and mount_target
. For object storage, these are namespace
and path
.
We'll have a pre-check for the keys for each type passed in so that user will be notified immediately if anything is missing or wrong.
Added support for mounting file storage for oci job
with_storage_mount()
andstorage_mount
forDataScienceJob
:DSCFileStorage
to hold the required arguments for file system mountingUnit test