AQUA Fetch HF Model Details #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrDzurb
requested review from
darenr,
mayoor,
VipulMascarenhas and
qiuosier
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
mingkang111
approved these changes
May 9, 2024
VipulMascarenhas
approved these changes
May 9, 2024
| model_id_lower = model_id.lower().replace(f"{author}/", "") | ||
| author_lower = author.lower() | ||
|
|
||
| compartment_id = self.get_argument("compartment_id", default=None) |
There was a problem hiding this comment.
are we listing service models or UI is expected to pass compartment id / project id to list models in user compartment?
There was a problem hiding this comment.
The service models only. I copied this logic from models handler. I don't have a strong opinion here, it might be useful for some testing.
qiuosier
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://jira.oci.oraclecorp.com/browse/ODSC-56763
https://jira.oci.oraclecorp.com/browse/ODSC-56565
Implements:
Test
GET
POST
BODY
NEGATIVE
