Release/v1.0.3 #23
Merged
Release/v1.0.3 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aosingh
commented
Jun 10, 2022
aosingh
commented
- Clean up O$PT temporary tables which are created in dbt snapshots and incremental materialization
- Fixes [Bug] don't drop temporary table o$pt #12
- Support to create dbt model in custom schema. This might not work in ADBS because ADBS does not give ADMIN user DBA privileges but will work with on-prem database if the user has correct privileges.
- Fixes [Bug] ORA-00942 insert data to another schema #14
- Fixes Error while passing schema inside the model using {{ config(materialized='table',schema='schema')}} #2
- Addresses issues raised in PR Update adapters.sql #15
- dbt-oracle is now integrated with dbt_constraints
- Fixes [Bug] get_relation reporting dbt found an approximate match #5
- Refer dbt_adbs_test_project for examples
- Both Incremental materialization and Snapshots use temporary tables to stage new data. The data from the temp table is either merged or inserted into the target table. These temp tables are automatically truncated after the session exits, however they were never dropped. - This fix first truncates the temporary table and then drops it.
Fix/clean global temporary table
changes are to address issues when using custom schemas 1 - create schema call verifies database. As of 1.0.7 Oracle adapter allows for database parm not to be set since Oracle doesn't allow statement prefix to include database name. Trickle down effect of that change is 'create schema check' not working hence why lines are removed. There is even dummy-noop already in that method since you can't create schemas dbt-way in oracle (schemas are users). 2 - once #1 is addressed and custom schema is used, rename command will not find temp model table since schema is not passed as part of rename statement. Furthermore, rename statement will not work because Oracle doesn't support renaming tables that way. Alter Table to the rescue. changed from rename <table_original_name> to <table_new_name> to alter table <schema>.<original_name> rename to <table_new_name> tested with Python 3.9.1 dbt-core 1.0.7 dbt-oracle 1.0.2
1. Following macros changed or fixed in adapter.sql to use custom schema name - oracle__create_schema, oracle__create_view_as, oracle__alter_relation_comment, oracle__alter_column_type, oracle__drop_relation, oracle__truncate_relation, oracle__rename_relation, oracle__make_temp_relation 2. Changed view materialization strategy which unncessarily created an intermediate <model>__dbt_tmp view first and renamed it to the target view. Now we directly CREATE or REPLACE view <target_view_name> 3. Added generate_schema_name.sql as per dbt documentation in test project to determine the name of the schema that a model should be built in. 4. Changed a couple of models in the test project to use custom schema 5. Fixes Bug #14 6. Fixes Bug #2 7. Addresses issues raised in PR #15
…xisting relation then depending on the type we either drop or rename
Update adapters.sql
…hema Fix/manage objects in different schema
- Adapter method _make_match_kwargs() is updated to perform UPPER case comparison - Adapter method quote_seed_column() is updated to not quote seed cols by default - adapter.sql is updated to not lower case metadata - catalog.sql is updated to not lower case metadata - Incremental materialization needed a fix to perform a UPPER case comparison on the unique_key in ON clause - Added a test scenarios in dbt_adbs_test_project to test integration with dbt_constraints - Fixes Bug - #5
Fix/integration with dbt constraints
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Thomas Sapelza <sapelza.thomas@gmail.com>
Signed-off-by: Thomas Sapelza <sapelza.thomas@gmail.com>
Jinja whitespace control improvements
- Bumped version to v1.0.3 - Cleaned up README.md to consolidate docs to docs.getdbt.com side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.