Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source: reimplement text coordinates #53

Closed
mlvdv opened this issue Feb 16, 2016 · 0 comments
Closed

Source: reimplement text coordinates #53

mlvdv opened this issue Feb 16, 2016 · 0 comments
Assignees

Comments

@mlvdv
Copy link
Contributor

mlvdv commented Feb 16, 2016

The Source class contains support for describing text segments in several ways, including both 0-based character offsets and 1-based {row,line} coordinates. Although correctly documented, this support has a design flaw that makes it impossible to create a SourceSection that represents the contents of an empty Source instance. JRuby has needed a workaround for this, as likely have others. The "text map", its method documentation, and detailed tests must be reimplemented.

@mlvdv mlvdv self-assigned this Feb 16, 2016
@mlvdv mlvdv closed this as completed Apr 12, 2016
dougxc pushed a commit that referenced this issue May 23, 2016
…E.COM/truffle:feature/debugger-testing-fixes to master

* commit '8594994296f3f548a42ee3afe6b6e525c62da1de':
  Debugging: cleanup new Debugger testing framework in response to comments.
  Instrumentation:  compliant MIME type for InstrumentationTestLanguage
  Debugger:  import cleanup in tests
  Debugger:  reorganize and generalize testing framework, add new tests.
  Debugger:  create a language-agnostic testing framework for exercising the Debugger API, using the InstrumentationTestLanguage - first set of stepping tests - first set of breakpoint tests - reorganize some old tests in the directory
  Debugger:  fix two bugs in revised Breakpoint management:  a concurrent modification vulnerability plus incorrect identification of "enablement" for "disposed" breakpoints
  Debugger: fix bug created by Polyglot event propagation changes, breakpoints were not enabled unless "stepping into" the execution.
  Instrumentation:  upgrade InstrumentationTestLanguage with a command-line-friendly name and FileTypeDetector, used for new Debugger testing framework.
zakkak pushed a commit to zakkak/mandrel that referenced this issue Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant