-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "os.version" system property in SubstrateVM #557
Comments
@fcurts I will add support for the |
Important question on this topic. What's the policy of reusing code from main OpenJDK? I mean, we already have a code for os.version (and many other interesting things), maybe we should just migrate it (with reasonable refactorings)? |
Fixed by #568 The most straightforward solution, because os.version is quite fast. |
Reusing OpenJDK code, i.e., copying and pasting it, is ok from a licensing standpoint, however we must have a good reason to do so. If a feature can be implemented by reusing the JDK code without copying it, e.g., patching it through a substitution, then that is preferable. |
By the way, @olpaw is already working on getting the right |
@cstancu it's in final testing. It will land today (or tomorrow). |
Fixed in 4529207 This change adds system property support for:
|
Like the already supported "os.name" system property, "os.version" is often used in informational and diagnostic messages, which makes it worthwhile to support.
The text was updated successfully, but these errors were encountered: