Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#557] Add system property 'os.version' to the list of eager substitutions #568

Closed
wants to merge 1 commit into from
Closed

[#557] Add system property 'os.version' to the list of eager substitutions #568

wants to merge 1 commit into from

Conversation

olegchir
Copy link
Contributor

@olegchir olegchir commented Jul 25, 2018

Fixes #557.

Soft API change: new system property

oca-signed: Oleg Chirukhin
(http://www.oracle.com/technetwork/community/oca-486395.html)

@graalvmbot
Copy link
Collaborator

  • Hello Oleg Chirukhin, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address oleg -(at)- graalvm -(dot)- io. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

@cstancu
Copy link
Member

cstancu commented Jul 25, 2018

I think os.version should be a runtime computed value. By adding it to HOSTED_PROPERTIES you compute it at image build time, i.e., it is the os.version of the OS on which the image was built. While we can get away with it for os.arch and os.name for now since we don't have cross-compilation support the same doesn't apply for os.version.

@olegchir
Copy link
Contributor Author

@cstancu ok, I'll investigate it further, thank you

@olpaw
Copy link
Member

olpaw commented Jul 26, 2018

@olegchir I have a full implementation of os.version almost done that gets you the correct runtime value of os.version for linux and darwin. Stay tuned. It will land on master today or tomorrow.

@olpaw olpaw closed this Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants