Fix library paths for native library reporterchelper #4078
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new native shared library `reporterchelper` was introduced in oracle@e04a9cd However its location doesn't seem to be consistent with the location of other native libraries: Under windows the location seems to be completely wrong, as it ends up under `/bin/` and I would expect peakRSS to not work under windoes given that GraalVM [tries to load the library from `lib/svm/builder/lib/`](https://github.com/oracle/graal/blob/6fbf945cdd53fa0370f9c36a59058d912e3f6194/substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/reporting/ProgressReporterCHelper.java#L48): ``` $ find -name "*chelper*" ./lib/svm/clibraries/windows-amd64/libchelper.lib ./lib/svm/builder/clibraries/windows-amd64/libchelper.lib ./bin/svm/builder/lib/reporterchelper.dll ``` Under linux things look OK, but the library location is not platform dependent: ``` $ find -name "*chelper*" ./lib/svm/clibraries/linux-amd64/liblibchelper.a ./lib/svm/builder/clibraries/linux-amd64/liblibchelper.a ./lib/svm/builder/lib/libreporterchelper.so ```
|
Thanks for the PR, @zakkak!
You are right, RSS reporting is currently broken on Windows. I'll have a look at this tomorrow. |
|
I have pushed a different fix for this with 74b547b. Nonetheless, thanks for pointing out the issue and providing a possible fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new native shared library
reporterchelperwas introduced in e04a9cdHowever its location doesn't seem to be consistent with the location of other native libraries:
Under windows the location seems to be wrong, as it ends up under
/bin/, and I would expect peakRSS to not work under windoes given that GraalVM tries to load the library fromlib/svm/builder/lib/:Under linux things look OK, but the library location is not platform dependent: