Sort regions list for regions template variable presented by logging data source plugin #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
@huskerdhf @nagarnar , Here is my MR for the story - CDSCRS-27813. |
huskerdhf
reviewed
Oct 3, 2022
huskerdhf
reviewed
Oct 5, 2022
pkg/datasource.go
Outdated
| for _, item := range res.Items { | ||
| frame.AppendRow(*(item.Name)) | ||
| var regions []string | ||
| for _, regionName := range res.Items { |
There was a problem hiding this comment.
My comment related to the use of the item variable name was only about the for loop starting on line 327. Here the item variable name makes sense since the variable being looped over is res.Items. It is up to you whether you go back and revert this variable name change.
There was a problem hiding this comment.
I've approved the PR but if you go back and revert this variable name then I'll re-approve it.
There was a problem hiding this comment.
Understood. I have changed the variable name.
huskerdhf
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a user of Grafana dashboards that leverage the OCI logging data source plugin
I want to be easily select the regions I want the data panels on a dashboard to use in their queries
and see a sorted list of the possible regions in the regions template variable dropdown list
so that it is easier for me to locate the region(s) I am interested in within the regions list without necessarily typing in each region name.