Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helidon v2.1.0 #36

Merged
merged 16 commits into from
Sep 10, 2024
Merged

Helidon v2.1.0 #36

merged 16 commits into from
Sep 10, 2024

Conversation

aberinnj
Copy link
Member

@aberinnj aberinnj commented Sep 6, 2024

  • Dependencies still using JDBC v19 and other packages that may be uneccessary, Updated
  • No NPE guards for missing environment variables, Updated
  • Environment variables not homogenous, and undocumented, Updated
  • Add README for running instructions, Updated
  • Improve code to be more flexible, Updated

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 6, 2024
@aberinnj
Copy link
Member Author

aberinnj commented Sep 6, 2024

@Kuassim Please review when possible and merge

Copy link
Member

@Kuassim Kuassim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. One Java code does not have Copyright (unless I am not seeing right).
  2. Make sure to use 2 tabs for indentation at each level (it looks like you are using 3 and sometimes more than 3.
  3. Use try-with-resource for code blocks with statements and resultSets; to make sure these are closed/freed.

@aberinnj
Copy link
Member Author

aberinnj commented Sep 6, 2024

@Kuassim

  1. fixed
  2. fixed I hope! Some code are using builder methods so they may be indented more
  3. I do not see any files having this signature

@aberinnj
Copy link
Member Author

aberinnj commented Sep 6, 2024

@jeandelavarene Please review and merge when possible

@jeandelavarene jeandelavarene merged commit a870645 into helidon Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants