Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

information about merge statement #40

Closed
kubo opened this issue Oct 25, 2017 · 2 comments
Closed

information about merge statement #40

kubo opened this issue Oct 25, 2017 · 2 comments
Labels
bug

Comments

@kubo
Copy link

kubo commented Oct 25, 2017

dpiStmt_getInfo() returns incorrect information about merge.

I made a test program.
https://gist.github.com/kubo/d8b623072b755edd508896940be86e81
It printed:

SQL: merge info ...
  isQuery: 0
  isPLSQL: 0
  isDDL: 0
  isDML: 0
  statementType: 16
  isReturning: 0

Merge is DML but isDML is zero and statementType is a value not listed here.
In this example the statement is not a valid SQL but it returns same results even for valid statements.

Well, I cannot say that this is a bug due to odpi. That's because OCI_STMT_MERGE is not in OCI manual.
I hope that the Oracle team says 16 is the statement type of merge.
@anthony-tuininga
Copy link
Member

@kubo, thanks for pointing this out. I'll find out and get back to you!

anthony-tuininga added a commit that referenced this issue Oct 27, 2017
@anthony-tuininga
Added suport for MERGE statements, as requested
da81b31 
(#40).
@anthony-tuininga
Copy link
Member

As you can see I have added code to support MERGE statements, as requested. It will get added to the OCI headers and documentation at some point, but it is added to the ODPI-C documentation and headers now. Thanks again for pointing it out!

vrogier added a commit to vrogier/ocilib that referenced this issue Nov 6, 2017
@vrogier
Added OCI_CST_MERGE statement type
a3281a3 
MERGE statement is not publically defined in OCI headers.
(see oracle/odpi#40) for more info about
missing declaration)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kubo @anthony-tuininga