This repository has been archived by the owner on Oct 31, 2019. It is now read-only.
use a systemd unit to manage ethtool options #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjfontaine
force-pushed
the
tj/ethtool_unit_file
branch
from
c665a18
to
8688f01
Compare
|
The correctness of the unit file and ethtool commands LGTM. I will defer to others on TF related bits. |
tjfontaine
force-pushed
the
tj/ethtool_unit_file
branch
from
8688f01
to
7979505
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a reboot would cause a BM2 or VM2 shape to re-enable the offload, and thus break.
Instead, disable offload via a unit file so changes are persisted across reboots.