Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Array#intersect?. #2832

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Implement Array#intersect?. #2832

merged 1 commit into from
Jan 19, 2023

Conversation

nirvdrum
Copy link
Collaborator

Fixes #2831: Implement Array#intersect?.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 17, 2023
@nirvdrum nirvdrum added shopify compatibility and removed OCA Verified All contributors have signed the Oracle Contributor Agreement. labels Jan 17, 2023
@nirvdrum nirvdrum added this to the 23.0.0 Release milestone Jan 17, 2023
@eregon
Copy link
Member

eregon commented Jan 18, 2023 •
edited
Loading

Thank you for the PR. @andrykonchin was already working this as noted in #2733.
Given his PR is more complete (coercion, more specs, passes specs :truffle) I suggest we merge his PR, but integrate the improvements from your PR in it (the fast path empty check and the additional spec examples).

@eregon eregon closed this Jan 18, 2023
@eregon
Copy link
Member

eregon commented Jan 18, 2023

Actually I'll reopen this since Andrii rebased his PR on top of yours, so both should hopefully be marked as merged.

@eregon eregon reopened this Jan 18, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 18, 2023
@graalvmbot graalvmbot merged commit 71f0778 into oracle:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compatibility OCA Verified All contributors have signed the Oracle Contributor Agreement. shopify
Projects
None yet
Milestone
23.0.0 Release (June 13, 2023)
Development

Successfully merging this pull request may close these issues.

Implement Array#intersect?
3 participants
@nirvdrum @eregon @graalvmbot