Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compatibility] Enable tests for Module#used_refinements #3097

Closed
wants to merge 1 commit into from
Closed

[Compatibility] Enable tests for Module#used_refinements #3097

wants to merge 1 commit into from

Conversation

itarato
Copy link
Collaborator

@itarato itarato commented Jun 7, 2023 •
edited
Loading

Source: #3039

[already done, just need to untag specs/tests] Module.used_refinements has been added. [Feature #14332]

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 7, 2023
@itarato itarato self-assigned this Jun 7, 2023
@itarato itarato added the shopify label Jun 7, 2023
itarato
itarato commented Jun 7, 2023
View reviewed changes
test/mri/tests/ruby/test_refinement.rb
@@ -1791,13 +1791,17 @@ module RefA
refine Object do
def in_ref_a
end

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From: https://bugs.ruby-lang.org/projects/ruby-master/repository/git/revisions/21ee5341f8fc4ca513295dff2148f7c203c908a7/diff

@itarato itarato marked this pull request as ready for review June 7, 2023 21:28
@eregon eregon added the in-ci The PR is being tested in CI. Do not push new commits. label Jun 8, 2023
@eregon
Copy link
Member

eregon commented Jun 12, 2023

MRI tests fail with:

  1) Failure:
TestRefinement#test_used_refinements [/b/b/e/main/test/mri/tests/ruby/test_refinement.rb:1852]:
<[#<refinement:Object@TestRefinement::VisibleRefinements::RefB>,
 #<refinement:Object@TestRefinement::VisibleRefinements::RefA>]> expected but was
<[#<refinement:Object@TestRefinement::VisibleRefinements::RefA>,
 #<refinement:Object@TestRefinement::VisibleRefinements::RefB>]>.

@itarato itarato force-pushed the feature/PA-Add-Module-used_refinements-tests branch from f3e10f8 to 32d7445 Compare June 12, 2023 14:20
@itarato
Copy link
Collaborator Author

itarato commented Jun 12, 2023

MRI tests fail with:

  1) Failure:
TestRefinement#test_used_refinements [/b/b/e/main/test/mri/tests/ruby/test_refinement.rb:1852]:
<[#<refinement:Object@TestRefinement::VisibleRefinements::RefB>,
 #<refinement:Object@TestRefinement::VisibleRefinements::RefA>]> expected but was
<[#<refinement:Object@TestRefinement::VisibleRefinements::RefA>,
 #<refinement:Object@TestRefinement::VisibleRefinements::RefB>]>.

@eregon Fixed by making the refinement collection into a list instead of a set: https://github.com/oracle/truffleruby/pull/3097/files#diff-679de203cd6002a1f0e9ddf2f16d66aaf42e10c0fd861f9363ee03b0b224db40R2336

@itarato itarato removed the in-ci The PR is being tested in CI. Do not push new commits. label Jun 12, 2023
@itarato
Copy link
Collaborator Author

itarato commented Jun 12, 2023

Removed the in-ci label as a flaky test was fixed.

@itarato itarato requested a review from eregon June 12, 2023 14:22
@eregon eregon added the in-ci The PR is being tested in CI. Do not push new commits. label Jun 21, 2023
@eregon eregon self-assigned this Jun 21, 2023
@eregon
Copy link
Member

eregon commented Jul 6, 2023

I rebased this, fixed the conflicts, and submit it for merge.

graalvmbot pushed a commit that referenced this pull request Jul 6, 2023
@eregon
[GR-19220] Enable tests for Module#used_refinements (#3097)
00c67fc 
PullRequest: truffleruby/3864
@eregon
Copy link
Member

eregon commented Jul 7, 2023

Merged in 00c67fc

@eregon eregon closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon Awaiting requested review from eregon

Assignees

@eregon eregon

Labels
in-ci The PR is being tested in CI. Do not push new commits. OCA Verified All contributors have signed the Oracle Contributor Agreement. shopify
Projects
None yet
Milestone
23.1.0 Release (September 19, 2023)
Development

Successfully merging this pull request may close these issues.
2 participants
@itarato @eregon