[Bugfix] Fix method visibility in some corner cases #3143
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing some inconsistencies between truffle/cruby on how added method visibility is derived: #3134
Related Ruby issue: https://bugs.ruby-lang.org/issues/19749
Expectation
define target == current callFrame self
-> use scope visibilityThis PR is fixing these cases:
Redefine private method but outside of its context (should be public)
Redefine public method in the same context as private (should be private)