Skip to content
This repository was archived by the owner on Apr 6, 2022. It is now read-only.

Conversation

patte
Copy link
Contributor

@patte patte commented Mar 12, 2018

No description provided.

@patte patte changed the base branch from master to disable-webp March 12, 2018 16:48
@patte patte changed the base branch from disable-webp to master March 12, 2018 16:48
@coveralls
Copy link

coveralls commented Mar 12, 2018

Pull Request Test Coverage Report for Build 50

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.783%

Totals Coverage Status
Change from base Build 47: 0.0%
Covered Lines: 93
Relevant Lines: 136

💛 - Coveralls

patte and others added 19 commits March 13, 2018 13:03
shows all mutations to the eventLog table for the user, identifies actions (TOKEN_REQUEST,
AUTHORIZE_SESSION, etc), maps active session
…ship and new pledge PAID_INVEST

new ENVs: ADMIN_FRONTEND_BASE_URL, SLACK_CHANNEL_ADMIN, SLACK_CHANNEL_FINANCE
moves the pledge and accompanying (unclaimed) memberships from one user to another
Moves a memberships from one user to another, like it was claimed except it doesn't get activated
adminNotes are only visible and mutatable by supporters
…_SUBSCRIPTIONS in cf_pledge mai

if true the user should check his/her memberships subscriptions most propably she has a running
monthly- and yealy-membership simultaneously
generates a pledge (payment method: PAYMENTSLIP) with one membership (type: ABO) for the specified
user
error message for unauthorized roles fixed
@lukasbuenger lukasbuenger temporarily deployed to republik-api-staging March 30, 2018 16:27 Inactive
@lukasbuenger lukasbuenger temporarily deployed to republik-api-staging March 30, 2018 16:48 Inactive
birthday,
phoneNumber
}, {skipUndefined: true})
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: If I passed lastName: undefined but firstName: 'Luki', wouldn't lastName be set to undefined? Not really an issue atm, as the client still expects a complete particulars/address set.


const user = userId
? await pgdb.public.users.findOne({ id: userId })
: me
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if I enter a invalid (read non-existent) user id I just implicitly update my own prefs? Is this intentional?

@lukasbuenger lukasbuenger merged commit 8a19063 into master Apr 4, 2018
@lukasbuenger lukasbuenger deleted the admin branch April 10, 2018 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants