This repository was archived by the owner on Apr 6, 2022. It is now read-only.
Fixes before stitches #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sync nl subscriptions
switching from a monthly to a reduce membership should be possible, discussed with lolo
uxengine
approved these changes
Feb 23, 2018
| inactiveMemberships.sort((a, b) => ascending(a.sequenceNumber, b.sequenceNumber)) | ||
|
|
||
| const electedMembership = ( | ||
| inactiveMemberships.find(m => m.voucherCode === null) || |
There was a problem hiding this comment.
Is this line necessary considering || !m.voucherCode in line 43?
There was a problem hiding this comment.
yes because above it ensures that only none give abos or redeemed give abos are considere for activation. Here it says that a reedemed abo should be used first (same logic as January activation).
There was a problem hiding this comment.
Ah, so basically a null voucherCode represents redeemed, while a "normal" membership would have an undefined voucherCode, correct? (Just trying to understand)
There was a problem hiding this comment.
normal inactive memberships have a voucherCode string
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switching from a monthly to a reduced yearly should be allowed. generally the restriction is somewhat arbitrary.