Skip to content

Conversation

jlapenna
Copy link

This also required updating calls to fetch_token to include_client_id, as needed by the withings/nokia API.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e80c3ab on jlapenna:master into cbae16f on orcasgit:master.

@coveralls
Copy link

coveralls commented Jun 18, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 6006ff8 on jlapenna:master into cbae16f on orcasgit:master.

@brad
Copy link
Member

brad commented Jun 18, 2019

@jlapenna Looks like we should drop support for Python 3.4. Can you make the change?

@jlapenna
Copy link
Author

I can definitely do that. I've never used worked with travis CI before so it might take me a minute or six to figure out how to stop testing/supporting py3.4

@jlapenna
Copy link
Author

Alright (I'm also new to github), I pushed my changes to my fork, which according to the comments here should maybe trigger test re-runs.

@jlapenna
Copy link
Author

Hm. This seems to still use the tox.ini in your branch, so I'm not sure how to trigger it with this pull request.

@brad
Copy link
Member

brad commented Jun 18, 2019

@jlapenna That is right, it just needs to be removed from .travis.yml as well

@jlapenna jlapenna changed the title Support newer arrow and requests-oauthlib dependencies Unsupport py34; Support newer arrow and requests-oauthlib dependencies Jun 19, 2019
@jlapenna
Copy link
Author

Looks correct, now. yay. I also updated the title of the pull request.

Copy link
Member

@brad brad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some inline comments (questions) about the changes

Copy link
Author

@jlapenna jlapenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done a code review in a git pull request before, so I don't know if I resolved your comments correctly. Let me know.

@jlapenna
Copy link
Author

I haven't done a code review in a git pull request before, so I don't know if I resolved your comments correctly. Let me know.

@jlapenna jlapenna closed this Jun 26, 2019
@jlapenna jlapenna reopened this Jun 26, 2019
@jlapenna
Copy link
Author

@brad I have made all the requested changes.

Copy link
Member

@brad brad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brad
Copy link
Member

brad commented Jul 11, 2019

:shipit:

@brad brad merged commit 5b2893a into orcasgit:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants