Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes (#141 #138 #131) #146

Merged
merged 9 commits into from
Jan 18, 2023
Merged

Bug fixes (#141 #138 #131) #146

merged 9 commits into from
Jan 18, 2023

Conversation

Valecant
Copy link
Contributor

@Valecant Valecant commented Jan 10, 2023

Proposed changes

Fixing some little issues related to the functionality and the UI

Types of changes

What types of changes does your code introduce to the project: Put
an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (improve documentation)
  • Continuous Integration (functionality that improve automation or testing)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to
ask. We're here to help! This is simply a reminder of what we are going
to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the Contributor License Agreement
  • I have updated the RELEASE NOTES
  • I have added tests that prove my fix is effective or that my
    feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in
    downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion
by explaining why you chose the solution you did and what alternatives
you considered, etc...

Copy link
Contributor

@chicco785 chicco785 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments. i will try to have a round (including "visual" testing) with @c0c0n3 tomorrow

configuration-api/main/mongo/tenantsQueries.js Outdated Show resolved Hide resolved
src/pages/policyPage.js Show resolved Hide resolved
src/pages/policyPage.js Show resolved Hide resolved
@Valecant Valecant changed the title Bug fixes (#141 #138 #131 #127) Bug fixes (#141 #138 #131) Jan 11, 2023
@chicco785 chicco785 merged commit 6cd059a into master Jan 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2023
@Valecant Valecant deleted the bugFixes branch February 6, 2023 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants