-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experiment database file in orcmkit matlab version! #3
Comments
problem in these lines: @RDickes: do you plan to share these mat files or the users are supposed to implement their own? |
Hi, Tonight I will push a new version without the need of these files! |
Hi, RDickes |
@RDickes did you upload the new version to remove your path dependency? |
Good evening RDickes and Davide, I tried to use the matlab code ORCmKit but I had a problem:
Error in ==> OrcModel5 at 61 Thank you in advance and best regard, Marco M |
Hi Marco, It seems I did not fixed all the problems, I'll check this tonight. You will have a working version of the codes by friday for sure. |
@RDickes : I think you can copy the .mat file inside this Matlab folder here in GitHub and change the directory so it would be easier for the users to do some debugging |
Thank you so much RDickes, Bye bye, MarcoM |
Good Morning guys, I would like to ask to @RDickes if he have revised the directory in the MATLAB files of the ORC model? Have you added the .mat file in the folder? Bye bye Marco M |
Hi Marco,
Since I am still actively updating/improving these models, the different comments I made in the codes might not be all up-to-date. If you are lost or confused somewhere, just contact me and I will help you. Hope you will like it, RDickes |
Hi RDickes, Thank you so much for your improvements on the codes. I have solved my problems with coolprop and I tryed the run of your codes:
Error in HexModel (line 533) In your opinion this is a problem of the code or am I doing something wrong? best regards, MarcoM |
Hi Marco, The zeroBrent function is in the 'auxiliary functions' folder, you just need to add the 'ORCmKit\Matlab\Auxilliary functions' folder in your Matlab path |
Ok, tank you so much Rémi. Marco M |
Hi Marco, The zeroBrent function is in the 'auxiliary functions' folder, you just Le 23/10/2016 à 09:18, MarcoM-ORC a écrit :
Rémi DICKES PhD candidate/FRS-FNRS research fellow L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. |
Hi Rémi, I am now trying to run the matlab simulation using ORC model. I would like to ask to @RDickes if he could add the .mat file for the loss model in the folder? DP_folder = [path '\PressureDrops']; Thank you so much!! Jenny |
Hi Jenny, Cheers, |
Hi Rémi @RDickes , Thanks for uploading the an example of pressure drop parameters in the folder. I have went through the expander model and loss model, both ok. However, the HEX model, having a fatal error as presented below: HexModel Error in CoolProp.PropsSI (line 2) Error in sf_PropsSI_bar (line 24) Error in HEX_Qdotmax (line 171) Error in HexModel (line 869) And when I trying to run the ORC model, it shows the same error message. Could you help me to solve this problem? Thanks a lot. Best regards, |
Hmm, that's a problem from CP, not the model itself. Could you send me an example of conditions when it crashed? For which fluid/P,T does the code fail? Is it only when computing the conductivity, or also with other properties ? |
@RDickes Thanks for you reply. I have sent the example through email to you. |
Hi Jenny,
The first error you are referring to is due to a miscalculation of the
fluid property. It seems that the code tries to use CoolProp for
computing the properties of the HTF Pirobloc, which is not possible (it
is a fluid implemented manually in /the sf_PropsSI_bar/ function, it is
not implemented in the CP library). I think the problem comes from a
wrong parameter "param.type_h" provided to the heat exchanger model.
Indeed, the HexModel function can handle both suplly enthalpies and
temperatures as inputs for characterizing the fludis. Enthalpies are
used for compressible fluids (and their properties are computed with
CoolProp) while temperatures are used to simulated incompressible fluids
(and their properties are calculated with the /sf_PropsSI_bar/
function). In order to specify either if the supply properties are
temperatures or enthalpies, you must specify the param.type_h and
param.type_c parameters. So if I were you, I would check that you are
using a param.type_h = 'T' and not a param.type_h = 'H' when modelling
the HTF Pirobloc Basic.
Le 23/12/2016 à 12:50, daebk12 a écrit :
…
@RDickes <https://github.com/RDickes> Thanks for you reply. I have
sent the example through email to you.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHOunpVvpwkspgRJBpRCiPi-PYwlY-rvks5rK7VygaJpZM4Jr5aN>.
--
Rémi DICKES
PhD candidate/FRS-FNRS research fellow
University of Liège - Faculty of Applied Sciences
Energy System Research Unit
Campus du Sart Tilman, Quartier Polytech 1
Allée de la Découverte 17 - Bât. B49 (P33)
B–4000 LIEGE (BELGIUM)
rdickes@ulg.ac.be
+32 494.59.2253
+32 43.66.48.16
---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus
|
Jenny, for your second question, I have just added the gamma_R245fa.mat
file in the "Fluid properties" folder. You should have access to it now
Le 23/12/2016 à 12:50, daebk12 a écrit :
…
@RDickes <https://github.com/RDickes> Thanks for you reply. I have
sent the example through email to you.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHOunpVvpwkspgRJBpRCiPi-PYwlY-rvks5rK7VygaJpZM4Jr5aN>.
--
Rémi DICKES
PhD candidate/FRS-FNRS research fellow
University of Liège - Faculty of Applied Sciences
Energy System Research Unit
Campus du Sart Tilman, Quartier Polytech 1
Allée de la Découverte 17 - Bât. B49 (P33)
B–4000 LIEGE (BELGIUM)
rdickes@ulg.ac.be
+32 494.59.2253
+32 43.66.48.16
---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus
|
Hi @RDickes x0 evaluation: 1/81 Error in OrcModel>OrganicRankineCycle_init2 (line 909) Error in OrcModel (line 178) However, if I run the pumpmodel.m individually, the model is ok. Thanks. Jenny |
Hi @daebk12 Could you please help us to figure it ou? @davideziviani and @RDickes |
I don't know where to find these files, please help me and fix this bugs!
The text was updated successfully, but these errors were encountered: