Remove height restriction from input #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😍 ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default input fields in find dialog are single-lined, but when you paste multi-lined text they could expand so you could adjust a text you’re searching or replacing. I always though that it’s Atom’s fault that those fields are not expanded, but today I realized that it caused by
height: 24pxline in Atom Light/Dark, Unity UI and probably some other themes. In One Dark/Lite theme it works much better.So here’s how it looks now with multiline text pasted:
And how it will work with my PR merged and released:
I think it makes search much more powerful. I hope you’ll agree.