[android] New About screen #4439

rtsisyk · 2023-02-11T11:03:07Z

I did my best to update translations... It would be nice to fit each item into one line, but this is not critical.

Edited: actualize screenshots

data/strings/strings.txt

Jean-BaptisteC · 2023-02-11T14:27:27Z

Really good changes !

Is it normal if blue accent color have been replace by green ? (When you long press buttons, blue accent color is always used)
Icons is missing in bottom sheet to access to settings and bottom sheet about each list of bookmarks
What about dark mode ? (In dark mode, color is blue accent color, and in About screen, OM icon is too dark)

rtsisyk · 2023-02-11T16:40:20Z

Really good changes !

Thanks for testing!

Is it normal if blue accent color have been replace by green ? (When you long press buttons, blue accent color is
always used)

This blue MAPS.ME accent color wasn't updated during initial re-styling just by a mistake. I accidentally changed this part in this PR and it looked better to me. However, it looks like a distraction of the primary goal of this PR. I am extracting this change into #4444 and reverting here to avoid any speculations.

Icons is missing in bottom sheet to access to settings and bottom sheet about each list of bookmarks

Fixed, thanks! This dangling "else" clause without brackets is really error-prone.

What about dark mode ? (In dark mode, color is blue accent color, and in About screen, OM icon is too dark)

+1 I am also not satisfied with the color of the logo in dark mode, but this is the same color as on Splash screen. I thought about changing it to white in both places, but probably it would be better to address separately.

Jean-BaptisteC · 2023-02-11T17:51:32Z

Maybe we can create a different disposition for tablets in landscape mode ?
Just separate screen horizontally with first part in left (OM icon, up to report a bug button) and second part in right with all links

rtsisyk · 2023-02-12T05:20:46Z

Maybe we can create a different disposition for tablets in landscape mode ?

Just separate screen horizontally with first part in left (OM icon, up to report a bug button) and second part in right with all links

I haven't started with landscape yet.

rtsisyk · 2023-02-12T07:24:10Z

Added OSM data version as @biodranik desperately wanted.

android/res/values-zh/strings.xml

data/strings/strings.txt

android/res/values-de/strings.xml

iphone/Maps/LocalizedStrings/de.lproj/Localizable.strings

matheusgomesms

PT and PT-BR fix

android/res/values-pt-rBR/strings.xml

android/res/values-pt/strings.xml

data/strings/strings.txt

rtsisyk · 2023-02-16T08:51:01Z

Restored original landscape layout completely untouched since it is out of scope for this PR
Removed "Please fix map data at OpenSTreetMap.org" line based on feedback
Fixed weird data formatting: "от 16 дек 2022 г.."
Updated translation texts
Fixed Arabic, Farsi, Hebrew for the next text (see ./tools/unix/translate_categories.sh generates garbage for Arabic, Hebrew, Farsi #4499 for details explanation of problems)

nautilusx · 2023-02-16T09:15:26Z

@rtsisyk Can you please provide all other components (news, app strings,...) on weblate. It's easier for all and we can increase the quality. You can automagically merge the translations and the translators have an easier way to translate.

biodranik · 2023-02-16T18:10:11Z

Can you please provide all other components (news, app strings,...) on weblate. It's easier for all and we can increase the quality. You can automagically merge the translations and the translators have an easier way to translate.

Unfortunately, weblate doesn't support our current developer workflow for editing app strings. By moving to weblate we significantly complicate strings editing and adding for all contributors. We're looking for solutions for this problem that will make it easy to contribute and review strings for developers, and for Weblate users.

d4f5409d · 2023-02-16T18:18:02Z

Can you please provide all other components (news, app strings,...) on weblate. It's easier for all and we can increase the quality. You can automagically merge the translations and the translators have an easier way to translate.

Unfortunately, weblate doesn't support our current developer workflow for editing app strings. By moving to weblate we significantly complicate strings editing and adding for all contributors. We're looking for solutions for this problem that will make it easy to contribute and review strings for developers, and for Weblate users.

Did you reach out to Weblate already? Maybe they could help you writing support for it.

android/src/app/organicmaps/Framework.java

biodranik · 2023-02-16T18:39:24Z

android/src/app/organicmaps/help/HelpFragment.java

+    setupItem(R.id.report, isLandscape, root);
+
+    final TextView supportUsView = root.findViewById(R.id.support_us);
+    if (BuildConfig.FLAVOR.equals("google") && !TextUtils.isEmpty(mDonateUrl))


Let's remove this check and see if it works with the changed wording.

I didn't get what you propose.

I propose to always show support us. And use the hand with the heart icon for it.

OK, I have changed "Support us" to "Support the project" as was requested above. I am not sure that new wording is really much different to get away with it. Let's keep it disabled for Google Play for now.

The icon is already "hand with the heart", no changes by this patch.

data/strings/strings.txt

biodranik · 2023-02-16T19:20:29Z

Did you reach out to Weblate already? Maybe they could help you writing support for it.

Yes, they do not support https://github.com/scelis/twine strings format that we're using (see data/strings/strings.txt for example).

It is possible however to write a Weblate addon that will support it.

mpawelski

Polish translations suggestions. Mostly fixes in conjugations because we are talking about "aplikacja" and the sentence about battery drain didn't sound natural.

data/strings/strings.txt

android/res/values-de/strings.xml

biodranik · 2023-02-17T21:51:48Z

android/res/drawable/logo.xml

@@ -0,0 +1,10 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"


The logo is not visible in the dark theme.

Yeah... the night (a.k.a dark) theme is implemented in some custom way which make it is hard to maintain. I will try to deal with styles and fix this issue and accent colors.

setTint can help here, right?

setTint with what value? Styles are a bit messy and require refactoring.

I've solved this problem. Logo is now white in the dark mode.

Wivik

Some suggestions for French lines.

android/res/values-fr/strings.xml

RedAuburn · 2023-02-19T21:08:46Z

android/src/app/organicmaps/maplayer/MapButtonsController.java

-      helpButton.setImageResource(R.drawable.ic_christmas_tree);
-      helpButton.getDrawable().setTintList(null);
+      helpButton.setImageResource(R.drawable.logo);
+      // Keep this button colorful in normal theme.


in my opinion, this doesn't look as good:

it might look better if the colour is changed to grey like the others? but the question mark was also good

Yes, it is intentionally green to attract attention... Otherwise users would just give us * star without even trying to read FAQ and/or report a bug... Anyway, we can experiment here.

I bet that any user will tap an unknown button/icon at least once.

Yes, it is intentionally green to attract attention...

I bet that any user will tap an unknown button/icon at least once.

I also agree with @endim8 that this doesn't look good. Also the current question mark looks fine for me and it's much clearer that it's something related to "help/about".

For me the clean UI is one of the best things in OM. I understand that you try to get more users to read the about page, but I think many users really wouldn't like to have default UI of OM to be more "attention screaming" just to avoid some negative reviews on app stores.

I have two alternative ideas:

Maybe some mixed approach would be valuable? Like having this button with green color after first install/update of application and render it in gray color after it's been clicked once?

Or have possibility to disable this this button in options page? Some toggle that when it's ON then the 4 buttons change to 3 buttons (without the About Page), and the About Page appears just as another position when you click "hamburger menu" button. However, this might seem a bit like over-complicating setting page for not huge benefit. On the other hand there is already option like "hide zoom buttons" that affect what GUI element appear on app, so there is some precedence.

@endim8 @mpawelski I agree with you in general and will try to improve the situation with this button in the next updates.

biodranik · 2023-02-25T20:37:48Z

android/AndroidManifest.xml

@@ -664,8 +664,7 @@

    <activity
        android:name="app.organicmaps.help.HelpActivity"
-        android:configChanges="orientation|screenLayout|screenSize"


It means that the activity will be recreated on screen rotation, and users will see a blank screen for a moment, more visible on older devices. Why is it mandatory for this PR?

To enable the previous landscape mode!

At least some TODO can be left here. Intentionally making the app slower does not fit well into Organic Maps "we are the fastest" approach.

What TODO? This change is needed to enable separate layout for portrait and landscape. Otherwise, screen rotation will use the previous layout.

TODO to enable it back when layout will not be recreated.

It will be recreated if we want a separate landscape mode.

biodranik · 2023-02-25T20:38:38Z

android/res/drawable/logo.xml

@@ -0,0 +1,10 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"


setTint can help here, right?

biodranik · 2023-02-25T20:39:50Z

android/res/values/styles-text.xml

@@ -28,6 +28,7 @@
  <style name="MwmTextAppearance.Headline">
    <item name="android:textSize">@dimen/text_size_headline</item>
    <item name="android:textColor">?android:textColorPrimary</item>
+    <item name="android:fontFamily">@string/robotoMedium</item>


What happens if this font is not installed on a device?

This string is overridden for old APIs.

data/strings/strings.txt

biodranik · 2023-02-25T20:43:51Z

android/src/app/organicmaps/util/bottomsheet/MenuAdapter.java

@@ -48,15 +48,9 @@ public ViewHolder onCreateViewHolder(ViewGroup viewGroup, int viewType)
  public void onBindViewHolder(ViewHolder viewHolder, final int position)
  {
    final MenuBottomSheetItem item = dataSet.get(position);
-    viewHolder.getContainer().setOnClickListener((v) -> onMenuItemClick(item));


По клику на лого можно приделать пасхалку.

Что практически предлагается сделать?

biodranik · 2023-02-25T20:45:09Z

android/src/app/organicmaps/Framework.java

+    {
+      return format.parse(String.valueOf(dataVersion));
+    }
+    catch (ParseException e)


Is this catch necessary?

ParseException is a checked exception.

vng · 2023-02-27T20:46:15Z

Take out "[strings] Regenerated." commit

data/strings/strings.txt

Signed-off-by: Roman Tsisyk <roman@tsisyk.com>

MetehanOzyurek · 2023-03-01T15:06:35Z

data/strings/strings.txt

+    sv = Kartografiska data från OpenStreetMap från och med %@. Det är som Wikipedia där du kan lägga till eller redigera platser för alla användare över hela världen.
+    sw = Takwimu za katuni kutoka kwa OpenStreetMap kama ya %@. Ni kama Wikipedia ambapo unaweza kuongeza au kuhariri maeneo kwa watumiaji wote ulimwenguni.
+    th = ข้อมูลการทำแผนที่จาก OpenStreetMap ณ ปี %@มันเป็นเหมือนวิกิพีเดียที่คุณสามารถเพิ่มหรือแก้ไขสถานที่สำหรับผู้ใช้ทุกคนทั่วโลก
+    tr = Harita verileri, %@ tarihine ait OpenStreetMap verilerinden alınmıştır. OpenStreetMap, Vikipedi'nin harita sürümü gibidir: dünyadaki herkes yer ekleyebilir veya düzenleyebilir.


tr = Harita verileri, %@ tarihine ait OpenStreetMap verilerinden alınmıştır. OpenStreetMap, Vikipedi'nin harita sürümü gibidir: dünyadaki tüm kullanıcılar için yer ekleyebilir veya düzenleyebilirsiniz.

This is the exact translation. But current is also OK.

rtsisyk requested review from biodranik, vng and arnaudvergnet February 11, 2023 11:03

rtsisyk commented Feb 11, 2023

View reviewed changes

data/strings/strings.txt Show resolved Hide resolved

rtsisyk force-pushed the rt-android-about-screen branch from 35e93b5 to a8baf8e Compare February 12, 2023 07:34

LaoshuBaby reviewed Feb 12, 2023

View reviewed changes

android/res/values-zh/strings.xml Outdated Show resolved Hide resolved

j13m126 approved these changes Feb 12, 2023

View reviewed changes

data/strings/strings.txt Show resolved Hide resolved

android/res/values-de/strings.xml Outdated Show resolved Hide resolved

iphone/Maps/LocalizedStrings/de.lproj/Localizable.strings Outdated Show resolved Hide resolved

vng added Android Android development UI User interface issues labels Feb 12, 2023

matheusgomesms suggested changes Feb 12, 2023

View reviewed changes

android/res/values-pt-rBR/strings.xml Outdated Show resolved Hide resolved

android/res/values-pt-rBR/strings.xml Outdated Show resolved Hide resolved

android/res/values-pt/strings.xml Outdated Show resolved Hide resolved

android/res/values-pt/strings.xml Outdated Show resolved Hide resolved

biodranik reviewed Feb 14, 2023

View reviewed changes

data/strings/strings.txt Show resolved Hide resolved

data/strings/strings.txt Outdated Show resolved Hide resolved

data/strings/strings.txt Outdated Show resolved Hide resolved

data/strings/strings.txt Outdated Show resolved Hide resolved

fitojb reviewed Feb 15, 2023

View reviewed changes

data/strings/strings.txt Outdated Show resolved Hide resolved

rtsisyk force-pushed the rt-android-about-screen branch from f5be101 to f79fe6a Compare February 16, 2023 08:44

biodranik reviewed Feb 16, 2023

View reviewed changes

mpawelski reviewed Feb 17, 2023

View reviewed changes

data/strings/strings.txt Show resolved Hide resolved

data/strings/strings.txt Show resolved Hide resolved

data/strings/strings.txt Show resolved Hide resolved

data/strings/strings.txt Show resolved Hide resolved

strump reviewed Feb 17, 2023

View reviewed changes

data/strings/strings.txt Show resolved Hide resolved

data/strings/strings.txt Show resolved Hide resolved

rtsisyk mentioned this pull request Feb 17, 2023

Weblate for localizing app UI string resources rtsisyk/github-playground#1

Open

j13m126 suggested changes Feb 17, 2023

View reviewed changes

android/res/values-de/strings.xml Outdated Show resolved Hide resolved

android/res/values-de/strings.xml Outdated Show resolved Hide resolved

android/res/values-de/strings.xml Outdated Show resolved Hide resolved

biodranik reviewed Feb 17, 2023

View reviewed changes

rtsisyk force-pushed the rt-android-about-screen branch from f79fe6a to b255621 Compare February 19, 2023 08:02

rtsisyk requested review from LaoshuBaby, mpawelski, strump, fitojb and biodranik and removed request for strump February 19, 2023 08:42

Wivik reviewed Feb 19, 2023

View reviewed changes

android/res/values-fr/strings.xml Outdated Show resolved Hide resolved

android/res/values-fr/strings.xml Outdated Show resolved Hide resolved

j13m126 approved these changes Feb 19, 2023

View reviewed changes

RedAuburn reviewed Feb 19, 2023

View reviewed changes

rtsisyk requested a review from strump February 20, 2023 07:14

rtsisyk force-pushed the rt-android-about-screen branch 3 times, most recently from 631b779 to ea93b0f Compare February 25, 2023 19:56

biodranik reviewed Feb 25, 2023

View reviewed changes

vng approved these changes Feb 27, 2023

View reviewed changes

MetehanOzyurek reviewed Feb 28, 2023

View reviewed changes

data/strings/strings.txt Show resolved Hide resolved

rtsisyk added 2 commits March 1, 2023 09:25

[android] New About screen

8b81216

Signed-off-by: Roman Tsisyk <roman@tsisyk.com>

[strings] Regenerated

4ae4784

Signed-off-by: Roman Tsisyk <roman@tsisyk.com>

rtsisyk force-pushed the rt-android-about-screen branch from ea93b0f to 4ae4784 Compare March 1, 2023 07:28

rtsisyk merged commit c6ebf7f into master Mar 1, 2023

rtsisyk deleted the rt-android-about-screen branch March 1, 2023 07:30

MetehanOzyurek reviewed Mar 1, 2023

View reviewed changes

Jean-BaptisteC mentioned this pull request May 21, 2023

[android] convert help screen to compose #5179

Draft

		@@ -0,0 +1,10 @@
		<vector xmlns:android="http://schemas.android.com/apk/res/android"

[android] New About screen #4439

[android] New About screen #4439

Conversation

rtsisyk commented Feb 11, 2023 • edited Loading

Jean-BaptisteC commented Feb 11, 2023

rtsisyk commented Feb 11, 2023

Jean-BaptisteC commented Feb 11, 2023

rtsisyk commented Feb 12, 2023

rtsisyk commented Feb 12, 2023

matheusgomesms left a comment

Choose a reason for hiding this comment

rtsisyk commented Feb 16, 2023

nautilusx commented Feb 16, 2023

biodranik commented Feb 16, 2023

d4f5409d commented Feb 16, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

biodranik commented Feb 16, 2023

mpawelski left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Wivik left a comment

Choose a reason for hiding this comment

RedAuburn Feb 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

biodranik Feb 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vng commented Feb 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rtsisyk commented Feb 11, 2023 •

edited

Loading

d4f5409d commented Feb 16, 2023 •

edited

Loading

mpawelski left a comment •

edited

Loading

RedAuburn Feb 19, 2023 •

edited

Loading

biodranik Feb 20, 2023 •

edited

Loading