You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The legacy-config re-check reads one open file, narrowing the gap before the delete
Fixed
The legacy-config re-check before the delete now reads the file through one open descriptor. The check compared the file's name with its content in two separate steps, which left a gap between the check and the read. The file is now opened once, its identity and its content are judged on that same descriptor, and the name is compared with it just before the delete. Behaviour is unchanged: a legacy file that changed or was replaced during the migration is kept, with a warning, and the run exits 1. A change between that last name check and the delete is still not seen: the window is narrowed, not closed. Tests: scripts/configure-migrate.test.mjs (the existing legs; no leg isolates the old two-step gap, as no leg could show a loss from it).
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
The legacy-config re-check reads one open file, narrowing the gap before the delete
Fixed
scripts/configure-migrate.test.mjs(the existing legs; no leg isolates the old two-step gap, as no leg could show a loss from it).Release page · CoalFace
All reactions