Security advisory PR in temporary private fork doesn't get updated even when branch is updated with some commits #204760
Replies: 4 comments
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
This comment was marked as spam.
This comment was marked as spam.
|
The push does land on the branch, it's the PR's head ref that never moves: So the branch ref is right, the pull ref is just sitting one commit behind. Which explains the symptom exactly: newest commit is there on the branch but missing from the PR, and the PR's commit count comes up one short. Useful side effect of that check, if the two SHAs don't match then it's this, not a push that quietly failed. For getting it unstuck, pushing a fresh SHA to the tip seems to make the pull ref catch up. An empty amend is enough, same content, different commit id: git commit --amend --no-edit --date="<original author date>"
git push --force-with-lease=refs/heads/<branch>:<expected-old-sha> <remote> <branch>Worked for me straight away. Pull ref jumped to the new SHA, lined up with the branch, and the missing commit and its diff finally rendered. Couple of things I'd watch for: Passing the original Check your review threads before force pushing. Comments pinned to earlier commits came through fine for me, but anything sitting on the commit you're amending will go outdated.
This is only papering over it though, nothing stopping it happening again on the next push. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
🏷️ Discussion Type
Bug
💬 Feature/Topic Area
Security Advisories/Private forks
Discussion Details
Security advisory PR in temporary private fork doesn't get updated even when branch is updated with some commits.
I have verified that some commits are pushed to the branch in the temporary private fork for a security advisory, but a PR opened from the same branch does not have the latest commit over there. Has to be a bug, which doesn't even get updated.
All reactions