Feature Request: Don't treat PRs as "waiting on my review" when there's an outstanding Team Review Request but I've already submitted a review #207933
Unanswered
crbunney
asked this question in
Pull Requests
Replies: 2 comments 1 reply
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
1 reply
This comment was marked as low quality.
This comment was marked as low quality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
🏷️ Discussion Type
Product Feedback
Body
User Story
AS a developer checking what pull requests I can review,
I WANT to be able to distinguish between pull requests I've already reviewed from those I haven't
SO THAT I can prioritise the review requests that only I can fulfil over those that any team member can fulfil.
I'm finding that the interaction between submitted reviews and team review requests is making this much harder.
Context
In the Pull Request UI
Example URL:
https://github.com/{org}/{repo}/pull/{id}Current Behavior
When I view a pull request that I've submitted a review for (and the review is not stale/dismissed), and the pull request has a team review request for my team, I see a prompt to review the pull request:

That's frustrating, because the PR is not waiting on my review: I've already submitted a review. It's waiting on a review from another person on my team, and I cannot action the prompt.
Desired Behavior
Give user review requests and submitted user reviews precedence over team review requests.
When my review is fresh: Ignore the team review request and do not prompt me to review the pull request again.
When my review is stale/dismissed: If there is a team review request or a user review request for me specifically, prompt me to review the pull request
In the Pull Request Inbox
URL: https://github.com/pulls/inbox
Current Behavior
The "Needs your team's review" section combines PRs I've already reviewed and PRs I haven't.
It's true that those PRs still need my team's review, but my main reason for looking at the PR inbox is to easily identify which PRs are blocked or actionable by me.
So, having PRs that I've already reviewed show up in the "Needs your team's review" section means I can't tell which PRs are actionable. I have to open each one to check if I've already reviewed it, which seems to defeat the point of the inbox.
Desired Behaviour
Either:
But either way, please ensure the separation of requests for reviews from me personally vs my team generally is kept (i.e. "Needs your review" vs "Needs your team's review"). This is important to me because it enables me to identify and prioritise the review requests that only I can action over the requests that others can fulfil.
Filter PRs from the "Needs your team's review" section that already have a fresh review from me
Adding additional filtering to remove the stuff I don't want to see in the "Needs your team's review" is my preferred solution.
It would require appending this to the existing filter:
-user-review-requested:@me -reviewed-by:@meThat would mean the full "Needs your team's review" filter would be:
Split the "Needs your team's review" section to separately display PRs I've reviewed and PRs I haven't
If, for some reason, adding extra filtering to the existing section isn't an acceptable option (perhaps because it supports another user story), then splitting the two filters out would be workable too.
The section names would probably need changing to be clear and easy-to-understand. For example, something like this:
All reactions