Sponsor dialog treats scheme-less custom funding URLs as repository-relative links #213186
Replies: 1 comment
|
Thank you for your interest in contributing to our community! We currently only accept discussions created through the GitHub UI using our provided discussion templates. Please re-submit your discussion by navigating to the appropriate category and using the template provided. This discussion has been closed because it was not submitted through the expected format. If you believe this was a mistake, please reach out to the maintainers. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
🏷️ Discussion Type
Bug
💬 Feature/Topic Area
Sponsors
Body
Scheme-less
customfunding URLs are used as relative links in the repository Sponsor dialog, sending visitors to a path on github.com instead of the funding site.Minimal configuration
.github/FUNDING.ymlon the default branch:Steps and actual result
https://github.com/torsher-app/paypal.me/antongithubinstead of PayPal.The same symptom affects https://github.com/massCodeIO/massCode: its PayPal link resolves to
https://github.com/massCodeIO/paypal.me/antongithub. Its scheme-less Gumroad custom link is affected too.Public configurations:
Expected result
Open the external funding site, normalizing the scheme-less URL before rendering the link. If a scheme is now required, validation and documentation should consistently say so.
The current documentation includes
octocat.comwithout a scheme. In the related documentation issue github/docs#35690, GitHub also clarified that scheme-less strings which become valid HTTP URLs when prefixed are accepted. That issue concerns format documentation/Packagist, rather than this Sponsor-dialog navigation bug.Verification details
Checked on 2026-11-15 using public HTTP responses and the shipped client code:
externalFundingLinks[0].urlaspaypal.me/antongithub.SponsorDialogexternal-link component passese.urldirectly tohref. Its filter checksnew URL(t.trim(), window.location.origin)but does not normalize the value passed tohref.These responses and the URL resolution match the reported navigation. The date this behavior began is unknown; this report does not establish a regression.
A repository-side workaround is an explicitly absolute URL:
All reactions