Stacked PR as Test Driven Development #213637
Unanswered
dahung-te
asked this question in
Pull Requests
Replies: 1 comment
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
🏷️ Discussion Type
Product Feedback
Body
Use case - Stacked PRs to natively support Test Driven Development
Stacked PRs can make a bug fix easier to review when the first PR demonstrates the bug and the next PR fixes it. Reviewers can see the failing tests in the first PR, then see those same tests pass in the fix PR.
Current behavior
The stacked PR merge requirements say:
This prevents merging the stack when a lower PR intentionally has a failing check, even if a later PR fixes the failure and the complete stack passes.
Proposed change
Allow a stack to merge when the combined result of the stack meets the target branch’s merge requirements, even if an earlier PR in the stack does not pass on its own.
There are two possible approaches:
In either approach, the merge should be blocked unless the final combined result satisfies the target branch’s required checks and protections. The UI should make clear which PRs have failing checks and which checks are being used to determine whether the complete stack can merge.
Example
Merging the stack would preserve the useful review history—the failing reproduction followed by the passing fix—without requiring the intermediate PR to be independently mergeable.
Expected behavior
All reactions