Repository nav: Issues and Pull requests counters stay stale until a full page reload (other tabs counters not checked) #213778
Unanswered
Pafer1
asked this question in
Projects and Issues
Replies: 1 comment
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
🏷️ Discussion Type
Bug
💬 Feature/Topic Area
Issues
Body
Summary
The open Issues and Pull requests counters in the repository navigation bar (Code / Issues / Pull requests / …) are not updated when issues or pull requests are created, closed or deleted outside the current browser tab: from the CLI, the API, another tab or another user. Switching between the repository tabs doesn't fix it, even when you open the Issues or Pull requests tab itself. Only a full page load updates the counters: a browser reload or a click on the Code tab, which does a full page load.
The result is that the counter and the list on the same screen disagree. For example, the Issues tab lists 13 open issues while the counter next to the tab still says 12.
Steps to reproduce
gh issue create(deleting an issue, or opening a PR withgh pr create, behaves the same way).Behavior
What I found while debugging (browser DevTools)
global-nav-barpartial payload has a non-nullcontextRegion.localNavigationUpdateChannel, and the page sends asubscribeframe for that channel over the Alive WebSocket. I watched the socket (withlocalStorage.bypassSharedWorker = "true"so it shows up in the page's Network panel) while creating and deleting issues and opening PRs. No message ever arrived for the nav channel.issueUpdatedmessages right away, so delivery to my browser is fine. The problem seems to be that nothing is published to the nav channel when the number of open issues or PRs changes.data-turbo-frame="repo-content-turbo-frame". The nav bar is rendered outside that frame, and the frame response doesn't include it. The global-nav context refresh only runs when the navigation context changes, for example when moving to another repository, not between tabs of the same repository.Guidelines
All reactions