How come value changes are evaluated different with same results #22969
-
Hi everyone! Can someone explain why these two changes are evaluated as different types of changes? The ending results are clearly the same, the values were changed from I’m guessing it has something to do with them having different datatypes? Like a tinyint compared to an int? I notice in this PR every value with 1 or 2 characters (50, 24, 4, etc) has the full value replaced, but every value with 3 characters (200, 400, 287, etc) shows only the apostrophes replaced. |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments
-
The diff machinery doesn’t care about datatypes. Everying is text to it 😃 This type of diff is called a ‘word diff’ and I guess the preimage needs to be 5 characters or longer for this part of the diff machinery to kick in. Though that’s just a guess, I have no idea about the actual internals. |
Beta Was this translation helpful? Give feedback.
-
Thanks for the response @seveas. Makese sense it’s all just evaluated as text and not actual types ha I assume there’s some efficiency logic once the diff string hits different lengths, but I’m curious exactly what it might be, or why (if simply for machine efficiency). |
Beta Was this translation helpful? Give feedback.
The diff machinery doesn’t care about datatypes. Everying is text to it 😃
This type of diff is called a ‘word diff’ and I guess the preimage needs to be 5 characters or longer for this part of the diff machinery to kick in. Though that’s just a guess, I have no idea about the actual internals.