[Edit pinned items] save pins button always disabled

[easyhooon]

Select Topic Area

Question

Body

I'm trying to update my GitHub profile by pinning 6 representative repositories. To make changes, I unchecked one of the existing pins and checked a new one. However, the 'Save pins' button is always disabled, making it impossible to update. I thought it might be a cache issue with Chrome, so I cleared the cache, but the problem persists. Please check this.

[fury-05]

Its a bug you can report it or just wait it will be resolved soon.

[rursache]

it's 1 may and it's still not fixed, just inspect element and remove the disabled css from the button

[adebayoAdesina]

It was working a few hours ago. There seems to be a bug.

[steve02081504]

guys just f12 in page and enter this in js repl:

document.querySelector('.js-pinned-items-submit').disabled = false

[Chiroyce1]

Is this really expected from GitHub? After probably lots of testing and ensured safe deployments an entire feature gets broken lol

Also never realised GitHub ships TS files to the client that appears to contain actual source code?!

[Chiroyce1]

It has been fixed now!

[simonc8]

I'm using Firefox. I opened the console and typed in

document.querySelector('.js-pinned-items-submit').disabled = false

It responded with the word false, but the Save Pins button remains "greened-out".

Despite statements that this has been fixed it's still not working.

[drok]

The button remains broken. It seems the 'fixed the glitch' that allowed the querySelector workaround to work.

The new workaround found by @praveenprem below did work for me.

[cybermaggedon]

Still broken. In FIrefox, right click on the greyed-out button, press Inspect. Edit the HTML and remove disabled="disabled". It then works.

[wesleybertipaglia]

Select Topic Area

Question

Body

I'm trying to update my GitHub profile by pinning 6 representative repositories. To make changes, I unchecked one of the existing pins and checked a new one. However, the 'Save pins' button is always disabled, making it impossible to update. I thought it might be a cache issue with Chrome, so I cleared the cache, but the problem persists. Please check this.

It's not working form me

[sampov2]

This is not working for me either, not fixed yet or faulty fix

[sampov2]

This actually only affects organizations for which no earlier pins exist. When the dialog is opened from the right hand side "You can pin repositories ..." link, the save button does not work.

[iskandr]

This is still a problem for me. I don't have previously pinned repositories and cannot save any new ones.

[simonc8]

What browser were you using? I can't seem to make this change in Firefox.
It says Uncaught SyntaxError: expected expression, got '<'

[simonc8]

@praveenprem
OK, I made it work. You have to double click on the disabled="disabled" text in the Inspect dialog and delete it. Then when you press Enter the button magically becomes available!!!

Many thanks for this,

[tkittel]

Amazing, thanks for the workaround. Github, please fix!

[karshPrime]

@simonc8 legend!!

[ahujaesh]

@simonc8 worked for me too, thanks

[Krumuvecis]

Still doesn't work

[connorgurney]

Still no change as of 19 February 2024.

[iskandr]

Kinda amazing.

…

On Mon, Feb 19, 2024, 4:21 PM Connor Gurney ***@***.***> wrote: Still no change as of 19 February 2024. — Reply to this email directly, view it on GitHub <#84168 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAL2OJFWS5ES2LSJNG64YTYUO65DAVCNFSM6AAAAABBNZHEF2VHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4DKMRSGIZDS> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[broofa]

Still an issue. Same symptoms as others: Org with no previously pinned repositories, had to delete the disabled attribute to be able to save.

I've filed a ticket for this: https://support.github.com/ticket/personal/0/2646573 (Not sure if anyone else will have access, but I'm including it here as a breadcrumb for future-me.)

[h1alexbel]

Still does not work. This one work around helps me. GitHub, please fix

[broofa]

Updated workaround

Run the following command in Developer Tools -> Console:

document.querySelectorAll('.js-pinned-items-submit').forEach(el => el.disabled = false)

Note

The above code works, but a simpler fix is to just resize your window to less than 768px wide.

"Why does this work," you ask?

Without going into too much detail, GH is embedding two "Pinned Item" components in the page to handle different page layouts. In "wide" mode, the logic that's supposed to enable the Save button is doing so for the wrong version of the component (the narrow-mode version rather than wide-mode version).

---

In other news, the issue I filed(my previous comment) is on GH's radar, but there's no ETA on when it'll get fixed:

[midnitelibrary]

This is still an issue as of April 29th, but this fix works.
Truly a great example of technology.
Thanks for figuring this out!

[broofa]

Update: I updated the support ticket I filed with my findings as to the cause of the problem (and probable fix). They forwarded the info to the eng. team and have closed the ticket since "there is no further support action we can take here".

Not much more to be done at this point. 🤷

[thasmo]

This is still broken in Firefox ...