Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix skipping ahead via upgrading OpenMPT to 0.7.0 (#52) #53

Merged
merged 1 commit into from
Jun 29, 2023
Merged

fix: Fix skipping ahead via upgrading OpenMPT to 0.7.0 (#52) #53

merged 1 commit into from
Jun 29, 2023

Conversation

Cthulhu2
Copy link
Contributor

@Cthulhu2 Cthulhu2 commented Jun 12, 2023 •
edited by orhun
Loading

OpenMPT Lib v0.5.1 -> v0.7.0
OpenMPT Core v1.41.1.2 -> v1.49.0.19

fixes #52

fix: Skip ahead w upgrade OpenMPT Lib v0.5.1 -> v0.7.0 (orhun#52)
4bf9d31 
OpenMPT Lib v0.5.1 -> v0.7.0
OpenMPT Core v1.41.1.2 -> v1.49.0.19
@vercel
Copy link

vercel bot commented Jun 12, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @orhun on Vercel.

@orhun first needs to authorize it.

@vercel
Copy link

vercel bot commented Jun 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cool-mod-files ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2023 10:24pm

@orhun
Copy link
Owner

orhun commented Jun 12, 2023

Great PR, thanks for this! 💖

Calling out @WKFO for testing, it is a core library so we need to make sure everything works properly.

See the preview here: https://cool-mod-files-git-fork-cthulhu2-fix-skip-ahead-52-orhun.vercel.app/

@orhun orhun requested review from orhun and WKFO June 12, 2023 22:32
@Cthulhu2
Copy link
Contributor Author

I did try to build libopenmpt, but it crashed on _openmpt_module_create_from_memory. May be it was an unstable branch... Finally, I tumbled to check out the modarchive.org. The libopenmpt from this urls:

@orhun
Copy link
Owner

orhun commented Jun 13, 2023

So are we using the same libopenmpt as modarchive?

@Cthulhu2
Copy link
Contributor Author

Yes.

$ wget https://modarchive.org/style/js/libopenmpt.js
...
$ sha256sum ./libopenmpt.js 
95abd981c41474e2f0a08f74619cd83c59fc30883426fdbd0b7ddfdde953de51  ./libopenmpt.js
$ sha256sum ./public/libopenmpt.js 
95abd981c41474e2f0a08f74619cd83c59fc30883426fdbd0b7ddfdde953de51  ./public/libopenmpt.js

$ wget https://modarchive.org/style/js/libopenmpt.wasm
...
$ sha256sum ./libopenmpt.wasm 
c52f1143ae789e2a7222259951c0785fca89fd821f0c153cb1617b574fb26b73  ./libopenmpt.wasm
$ sha256sum ./public/bin/libopenmpt.wasm 
c52f1143ae789e2a7222259951c0785fca89fd821f0c153cb1617b574fb26b73  ./public/bin/libopenmpt.wasm

WKFO
WKFO approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@WKFO WKFO left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have fixed the skipping problem. That's all I can say by testing, on the surface. Nice work.

@orhun orhun changed the title fix: Skip ahead w upgrade OpenMPT Lib v0.5.1 -> v0.7.0 (#52) fix: Fix skipping ahead via upgrading OpenMPT to 0.7.0 (#52) Jun 29, 2023
@orhun orhun merged commit 577a645 into orhun:master Jun 29, 2023
@Cthulhu2 Cthulhu2 deleted the fix/skip-ahead-#52 branch July 13, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WKFO WKFO WKFO approved these changes

@orhun orhun orhun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to skip ahead in track
3 participants
@Cthulhu2 @orhun @WKFO