Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comply with MD022? #60

Closed
kenji-miyake opened this issue Feb 6, 2022 · 4 comments · Fixed by #61
Closed

Comply with MD022? #60

kenji-miyake opened this issue Feb 6, 2022 · 4 comments · Fixed by #61
Assignees
Labels
feature/request New feature or request

Comments

@kenji-miyake
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The default configuration generates the changelog that violates a markdownlint rule MD022.

image

If there are no reasons for this, I feel it would be nice to comply with MD022.

Describe the solution you'd like

Just to add \n after # Changelog.

Before:

header = """
# Changelog
All notable changes to this project will be documented in this file.\n
"""

After:

header = """
# Changelog\n
All notable changes to this project will be documented in this file.\n
"""

Describe alternatives you've considered

Replace \n with a newline.

header = """
# Changelog

All notable changes to this project will be documented in this file.\n
"""

Additional context

Nothing.

@kenji-miyake kenji-miyake added the feature/request New feature or request label Feb 6, 2022
@kenji-miyake
Copy link
Contributor Author

@orhun How do you feel about it? If you don't mind, I'll send a PR.

@kenji-miyake
Copy link
Contributor Author

Also, let me confirm one more small thing here.

The word whitespaces will cause a spell-check error, so can I replace it with whitespace or whitespace characters?

# remove the leading and trailing whitespaces from the template

Reference: https://english.stackexchange.com/questions/25368/what-is-the-plural-form-of-whitespace

@orhun
Copy link
Owner

orhun commented Feb 6, 2022

@orhun How do you feel about it? If you don't mind, I'll send a PR.

Also, let me confirm one more small thing here.

The word whitespaces will cause a spell-check error, so can I replace it with whitespace or whitespace characters?

# remove the leading and trailing whitespaces from the template

Reference: english.stackexchange.com/questions/25368/what-is-the-plural-form-of-whitespace

Both things sound totally reasonable 👍🏼 Please go ahead and submit a PR.

@orhun orhun closed this as completed in #61 Feb 8, 2022
orhun pushed a commit that referenced this issue Feb 12, 2022
* feat(changelog, config)!: replace --topo-order by --date-order

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci: simplify test-fixtures workflow

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci: add fixtures tests of topo_order and date_order

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* remove unnecessary checkout

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* remove cargo run

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* set GIT_COMMITTER_DATE for each commit

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add a test for --date-order arg

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix git config style

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* remove an unnecessary period

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* apply #60

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* minify the config files for tests

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix git config style

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix styles of expected.md

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* make some steps one-line

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* remove footers

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* remove newlines

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Revert "remove newlines"

This reverts commit 8028815.

* Revert "remove footers"

This reverts commit 3d334cc.

* add trim and footer

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants