Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(args)!: prefix environment variables with GIT_CLIFF_ #76

Merged
merged 3 commits into from
Apr 4, 2022
Merged

feat(args)!: prefix environment variables with GIT_CLIFF_ #76

merged 3 commits into from
Apr 4, 2022

Conversation

uyha
Copy link
Contributor

@uyha uyha commented Apr 4, 2022

Description

Prefix environment variables with GIT_CLIFF_

Motivation and Context

#74

How Has This Been Tested?

Running cargo test returns successful.

Screenshots / Output (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@uyha uyha requested a review from orhun as a code owner April 4, 2022 19:01
@uyha uyha changed the title Prefix env Prefix environment variables with GIT_CLIFF_ Apr 4, 2022
orhun
orhun approved these changes Apr 4, 2022
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR! 🐻

@orhun orhun changed the title Prefix environment variables with GIT_CLIFF_ feat(args)!: prefix environment variables with GIT_CLIFF_ Apr 4, 2022
@orhun orhun merged commit 84507dd into orhun:main Apr 4, 2022
This was referenced Apr 4, 2022
Closed
Closed
@uyha uyha deleted the prefix-env branch April 5, 2022 10:46
@kaushalmodi kaushalmodi mentioned this pull request Apr 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun orhun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uyha @orhun