Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(readme): remove underscored spaces between badges #809

Merged
merged 1 commit into from
Aug 23, 2024
Merged

docs(readme): remove underscored spaces between badges #809

merged 1 commit into from
Aug 23, 2024
+13 −25

Conversation

oberrich
Copy link
Contributor

@oberrich oberrich commented Aug 22, 2024 •
edited
Loading

Description

This PR removes additional characters between each badge.

Motivation and Context

Underscored spaces don't look very nice.

See also: Explanation on why the browser emits extra whitespaces for <a href="..."><img> sequences with linebreaks

How Has This Been Tested?

Browser.

Screenshots / Logs (if applicable)

Before PR
image

After PR
image

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@oberrich oberrich requested a review from orhun as a code owner August 22, 2024 23:47
@welcome Welcome
Copy link

welcome bot commented Aug 22, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@oberrich oberrich mentioned this pull request Aug 23, 2024
Closed
orhun
orhun approved these changes Aug 23, 2024
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for attention in detail :)

@orhun orhun merged commit 1956c83 into orhun:main Aug 23, 2024
59 checks passed
@welcome Welcome
Copy link

welcome bot commented Aug 23, 2024

Congrats on merging your first pull request! ⛰️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun orhun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oberrich @orhun