Skip to content

Conversation

@rich-ayr
Copy link
Contributor

@rich-ayr rich-ayr commented Aug 22, 2024

Description

This PR removes additional characters between each badge.

Motivation and Context

Underscored spaces don't look very nice.

See also: Explanation on why the browser emits extra whitespaces for <a href="..."><img> sequences with linebreaks

How Has This Been Tested?

Browser.

Screenshots / Logs (if applicable)

Before PR
image

After PR
image

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rich-ayr rich-ayr requested a review from orhun as a code owner August 22, 2024 23:47
@welcome
Copy link

welcome bot commented Aug 22, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for attention in detail :)

@orhun orhun merged commit 1956c83 into orhun:main Aug 23, 2024
@welcome
Copy link

welcome bot commented Aug 23, 2024

Congrats on merging your first pull request! ⛰️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants