Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panics in library #87

Closed
kgilmer opened this issue Jul 8, 2023 · 2 comments
Closed

panics in library #87

kgilmer opened this issue Jul 8, 2023 · 2 comments
Assignees
@kgilmer
Labels
enhancement New feature or request

Comments

@kgilmer
Copy link
Contributor

kgilmer commented Jul 8, 2023

Hi! This issue is created as directed by CONTRIBUTING.md. First, I'm new to rust and found your freedesktop notification server very helpful as a project to hack on while learning the language. I am working on a fork for a DE that provides a different UI treatment for notifications. During testing I've noticed that if another notification dbus server is running, the service starts but does nothing. IMO better behavior would be to abort at this point. I'd be happy to create a PR to add this to runst if you agree. I'd also be curious to know you reasoning if you think runst should not abort under this scenario.

☮️
@kgilmer kgilmer added the enhancement New feature or request label Jul 8, 2023
@orhun orhun assigned kgilmer and unassigned orhun Jul 15, 2023
@orhun
Copy link
Owner

orhun commented Jul 15, 2023

Hello!

This would be a fair thing to implement I think.

I'd also be curious to know you reasoning if you think runst should not abort under this scenario.

I think I haven't really thought about this case 😅

I'd be happy to create a PR

Please go ahead!

kgilmer pushed a commit to kgilmer/runst that referenced this issue Aug 6, 2023
fix: fail if cannot be primary notification server on dbus
5d67bbb 
Addresses orhun#87
@kgilmer kgilmer mentioned this issue Aug 6, 2023
Merged
11 tasks
@kgilmer
Copy link
Contributor Author

kgilmer commented Aug 6, 2023

Ready for review at your convenience @orhun 🌷

orhun added a commit that referenced this issue Aug 9, 2023
@kgilmer @orhun
fix(dbus): fail if cannot be primary notification server (#107)
ed23396 
* fix: fail if cannot be primary notification server on dbus

Addresses #87

* refactor(dbus): refactor error handling

---------

Co-authored-by: Regolith Linux <regolith.linux@gmail.com>
Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
@orhun orhun closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgilmer kgilmer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgilmer @orhun