-
Notifications
You must be signed in to change notification settings - Fork 1
Migrate on_call_staging_test workflow to use Docker Compose with improved CI integration #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: dannystaple <426859+dannystaple@users.noreply.github.com>
docker-compose.yml
Outdated
cache_from: | ||
- type=gha | ||
cache_to: | ||
- type=gha,mode=max |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will this behave at the desk? It might only want to do this in the workflow run context - could it be specified there instead as a parameter/env var for the docker compose up command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the GitHub Actions cache configuration to a separate docker-compose.ci.yml
override file. This isolates the CI-specific cache settings from the main compose file, preventing any issues during local development. The workflow now uses both files with -f docker-compose.yml -f docker-compose.ci.yml
. Commit: 44deee4
…nfig to CI override Co-authored-by: dannystaple <426859+dannystaple@users.noreply.github.com>
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
This PR migrates the
on_call_staging_test
workflow from using standalone Docker commands to Docker Compose, providing better integration with the existing containerized development environment while addressing CI-specific concerns.Changes Made
Docker Compose Integration
staging
service todocker-compose.yml
that:_site
directory context using the staging DockerfileCI-Specific Configuration Isolation
docker-compose.ci.yml
override file to isolate GitHub Actions cache configurationdocker-compose.yml
to prevent issues during local development-f docker-compose.yml -f docker-compose.ci.yml
) for CI-specific behaviorStaging Dockerfile Updates
.github/scripts/staging/Dockerfile
to work with the_site
build contextdefault.conf
with correctServerRoot
path for thehttpd:2.4.64
imageWorkflow Improvements
docker compose --wait
flag for cleaner health check handlingBenefits
--wait
ensure service readiness before testingThe staging test maintains identical functionality while being more aligned with the project's Docker Compose-based development workflow and avoiding potential local development conflicts.
Fixes #228.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.