Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 4, 2025

The serve.Dockerfile has evolved to include multiple stages and targets serving various purposes in the project. The name no longer accurately reflects its broader functionality, so it has been renamed to the more conventional Dockerfile.

Changes Made

  • Renamed serve.Dockerfile to Dockerfile
  • Updated all 9 references in docker-compose.yml to use the new filename
  • Updated the GitHub workflow trigger path in .github/workflows/on_pr_test.yaml
  • Added Dockerfile to .eleventyignore to prevent it from being included in the built site

Validation

All Docker Compose services continue to work correctly with the new filename:

  • serve - Development server
  • dist - Build distribution
  • build - Eleventy build
  • test - BDD testing
  • shell - Debug shell
  • http_serve - Apache server
  • broken_links - Link checker
  • staging - Staging environment

The Dockerfile syntax and all multi-stage build targets remain unchanged, ensuring full backward compatibility while providing a cleaner, more standard naming convention.

Fixes #233.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: dannystaple <426859+dannystaple@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Rename serve.Dockerfile to a more general Dockerfile Rename serve.Dockerfile to Dockerfile and update all references Aug 4, 2025
@Copilot Copilot AI requested a review from dannystaple August 4, 2025 11:33
Copilot finished work on behalf of dannystaple August 4, 2025 11:33
@dannystaple dannystaple marked this pull request as ready for review August 4, 2025 11:35
Copy link
Contributor

github-actions bot commented Aug 4, 2025

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Warnings Elapsed time
❌ ACTION actionlint 5 6 0 0.08s
✅ BASH bash-exec 1 0 0 0.0s
✅ BASH shellcheck 1 0 0 0.06s
⚠️ BASH shfmt 1 1 0 0.0s
❌ C cppcheck 8 8 0 0.31s
❌ CPP cppcheck 8 8 0 0.3s
✅ JSON npm-package-json-lint yes no no 0.46s
✅ JSON v8r 12 0 0 7.77s
❌ MARKDOWN markdown-link-check 736 212 0 36.3s
✅ REPOSITORY gitleaks yes no no 13.52s
✅ REPOSITORY git_diff yes no no 1.05s
✅ REPOSITORY grype yes no no 35.66s
✅ REPOSITORY secretlint yes no no 42.94s
✅ REPOSITORY syft yes no no 1.65s
✅ REPOSITORY trivy-sbom yes no no 3.34s
✅ REPOSITORY trufflehog yes no no 4.5s
✅ XML xmllint 1 0 0 192.79s
✅ YAML v8r 13 0 0 6.39s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Co-authored-by: dannystaple <426859+dannystaple@users.noreply.github.com>
@Copilot Copilot AI requested a review from dannystaple August 4, 2025 11:55
Copilot finished work on behalf of dannystaple August 4, 2025 11:55
@dannystaple dannystaple merged commit 162b2b2 into master Aug 4, 2025
4 checks passed
@dannystaple dannystaple deleted the copilot/fix-233 branch August 4, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename serve.Dockerfile to a more general Dockerfile
2 participants