Skip to content

Make BDD tests exit code gating in staging workflow #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
Merged

Make BDD tests exit code gating in staging workflow #247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d81332
Initial plan
Copilot Aug 7, 2025
1f3fde6
Make BDD tests exit code gating - complete implementation
Copilot Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/on_call_staging_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,18 +56,19 @@ jobs:
echo "## BDD Test Results" >> $GITHUB_STEP_SUMMARY
echo "\`\`\`" >> $GITHUB_STEP_SUMMARY
docker compose -f docker-compose.yml -f docker-compose.ci.yml run test 2>&1 | tee bdd_output.txt
bdd_exit_code=$?
bdd_result=$?
cat bdd_output.txt >> $GITHUB_STEP_SUMMARY
echo "\`\`\`" >> $GITHUB_STEP_SUMMARY

if [ $bdd_exit_code -eq 0 ]; then
if [ $bdd_result -eq 0 ]; then
echo "✅ BDD tests passed" >> $GITHUB_STEP_SUMMARY
else
echo "⚠️ BDD tests failed (this is expected as step definitions are not yet implemented)" >> $GITHUB_STEP_SUMMARY
echo "❌ BDD tests failed" >> $GITHUB_STEP_SUMMARY
exit_code=1
fi

# Stop the service regardless of test outcome
docker compose -f docker-compose.yml -f docker-compose.ci.yml stop staging

# Exit with the test result (don't fail on BDD tests for now)
# Exit with the test result
exit $exit_code