Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#43 using lua-resty-jit-uuid #45

Merged
merged 2 commits into from
Dec 21, 2016
Merged

#43 using lua-resty-jit-uuid #45

merged 2 commits into from
Dec 21, 2016

Conversation

syhily
Copy link
Contributor

@syhily syhily commented Dec 16, 2016

No description provided.

@sumory
Copy link
Collaborator

sumory commented Dec 16, 2016

  • uuid.seed() should be invoked..
  • lua_code_cache should be on if we take lua-resty-jit-uuid as default uuid generator.

@syhily syhily closed this Dec 16, 2016
@syhily syhily reopened this Dec 16, 2016
@syhily
Copy link
Contributor Author

syhily commented Dec 16, 2016 •
edited
Loading

uuid.seed() could be called first when require a uuid string.
lua_code_cache off wouldn't be a problem after calling seed() method.

@syhily syhily closed this Dec 16, 2016
@syhily syhily reopened this Dec 16, 2016
sumory
sumory reviewed Dec 21, 2016
View reviewed changes
Copy link
Collaborator

@sumory sumory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! maybe we could refactor this part without global injection

@sumory sumory merged commit 9d5cb81 into orlabs:master Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumory sumory sumory left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syhily @sumory