-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/lightning upgrade #102
Merged
lorenzomammana
merged 24 commits into
feature/torch-upgrade
from
feature/lightning-upgrade
Feb 8, 2024
Merged
Feature/lightning upgrade #102
lorenzomammana
merged 24 commits into
feature/torch-upgrade
from
feature/lightning-upgrade
Feb 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade lightning to version 2.1.*
Refactor hydra plugins to use optional dev groups intend of extras to avoid dragging local packages around in external installations.
Hardcode specific pytorch versions to reduce the search space.
Improve trainer configs to avoid wrong overrides when calling different trainer overrides, add all trainer related configs inside the trainer configurations.
Refactor all lightning related code to support new code design from version 2
Type of Change
Checklist
Please confirm that the following tasks have been completed: