Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/lightning upgrade #102

Merged
merged 24 commits into from
Feb 8, 2024

Conversation

lorenzomammana
Copy link
Contributor

@lorenzomammana lorenzomammana commented Feb 6, 2024

Summary

Upgrade lightning to version 2.1.*

Refactor hydra plugins to use optional dev groups intend of extras to avoid dragging local packages around in external installations.
Hardcode specific pytorch versions to reduce the search space.
Improve trainer configs to avoid wrong overrides when calling different trainer overrides, add all trainer related configs inside the trainer configurations.
Refactor all lightning related code to support new code design from version 2

Type of Change

  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

lorenzomammana and others added 24 commits January 19, 2024 11:27
@lorenzomammana lorenzomammana marked this pull request as ready for review February 6, 2024 16:21
@rcmalli rcmalli self-requested a review February 8, 2024 14:21
@lorenzomammana lorenzomammana merged commit ad60d80 into feature/torch-upgrade Feb 8, 2024
@lorenzomammana lorenzomammana deleted the feature/lightning-upgrade branch February 8, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants